Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11461][Agent] HeartbeatManager does not create a DefaultMessageSender #11462

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented Nov 6, 2024

Fixes #11461

Motivation

To prevent interference from error logs

Modifications

HeartbeatManager does not create a DefaultMessageSender

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

No doc needed

@justinwwhuang justinwwhuang added this to the 2.1.0 milestone Nov 6, 2024
@justinwwhuang justinwwhuang self-assigned this Nov 6, 2024
@justinwwhuang justinwwhuang merged commit ad35873 into apache:master Nov 7, 2024
11 checks passed
@justinwwhuang justinwwhuang deleted the b11461 branch November 14, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] HeartbeatManager does not create a DefaultMessageSender
3 participants