Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11266][Sort] Add end-to-end test case for sort-connector-pulsar-v1.15 #11268

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

PeterZh6
Copy link
Contributor

@PeterZh6 PeterZh6 commented Oct 2, 2024

Fixes [Improve][Sort] Add end-to-end test case for sort-connector-pulsar-v1.15

Motivation

The sort-connector-pulsar-v1.15 requires an end-to-end (E2E) test to ensure robustness and facilitate the resolution of future issues related to metric monitoring and reporting. Additionally, this will help streamline the testing process for future bug fixes or feature implementations.

Modifications

  • Added an end-to-end test case for the sort-connector-pulsar-v1.15.
  • Introduced pulsar test container in root pom.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

Pulsar2SR1

After adding a while loop to stop the container from being torn down after testing, we can inspect the StarRocks table to verify this change:

PulsarSR2

Documentation

  • Does this pull request introduce a new feature? (yes / no) No
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) Not Documented
  • If a feature is not applicable for documentation, explain why? No New Feature Introduced

@XiaoYou201
Copy link
Contributor

plz provide some result shotcut~ thx~

@XiaoYou201
Copy link
Contributor

plz provide some result shotcut~ thx~

sorry~ I don't attention the fold~

@PeterZh6
Copy link
Contributor Author

PeterZh6 commented Oct 7, 2024

plz provide some result shotcut~ thx~

sorry~ I don't attention the fold~

Unfolded for clarity. Thanks for the attetion :)

vernedeng
vernedeng previously approved these changes Oct 8, 2024
@aloyszhang aloyszhang merged commit e97615d into apache:master Oct 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Sort] Add end-to-end test case for sort-connector-pulsar-v1.15
5 participants