-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-11028][SDK] Transform SQL support UrlEncode & UrlDecode functions #11031
Conversation
...rm-sdk/src/main/java/org/apache/inlong/sdk/transform/process/function/UrlEncodeFunction.java
Outdated
Show resolved
Hide resolved
@luchunliang @vernedeng @aloyszhang Sorry for demanding another review. I saw spotless process failed and recognized a useless import in a file so I redo the 'mvn spotless:apply' and re-commit. |
...rm-sdk/src/main/java/org/apache/inlong/sdk/transform/process/function/UrlDecodeFunction.java
Outdated
Show resolved
Hide resolved
@MOONSakura0614 please rebase from the master branch to fix the failed workflow. |
ef014df
to
9cdcd59
Compare
9cdcd59
to
26fb885
Compare
UT failed, PTAL |
delete test code in Function class Co-authored-by: AloysZhang <[email protected]>
…ions renew:Spotless apply for style check
…ions Update TestUrlDecodeFunction.java for return "" if pass null
…ions fixed UT null bug
7873a68
26fb885
to
7873a68
Compare
fixed. Thank you for pointing the bug. |
Fixes #11028
Motivation
Add 2 function class: UrlEncode & UrlDecode functions and their distinct unit tests.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation