Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11028][SDK] Transform SQL support UrlEncode & UrlDecode functions #11031

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

MOONSakura0614
Copy link
Contributor

@MOONSakura0614 MOONSakura0614 commented Sep 6, 2024

Fixes #11028

Motivation

Add 2 function class: UrlEncode & UrlDecode functions and their distinct unit tests.

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

luchunliang
luchunliang previously approved these changes Sep 9, 2024
vernedeng
vernedeng previously approved these changes Sep 9, 2024
@MOONSakura0614
Copy link
Contributor Author

@luchunliang @vernedeng @aloyszhang Sorry for demanding another review. I saw spotless process failed and recognized a useless import in a file so I redo the 'mvn spotless:apply' and re-commit.

aloyszhang
aloyszhang previously approved these changes Sep 22, 2024
luchunliang
luchunliang previously approved these changes Sep 26, 2024
@dockerzhang
Copy link
Contributor

@MOONSakura0614 please rebase from the master branch to fix the failed workflow.

aloyszhang
aloyszhang previously approved these changes Oct 11, 2024
@aloyszhang
Copy link
Contributor

UT failed, PTAL
TestUrlEncodeFunction.testUrlEncodeFunction:55 expected:<result=[]> but was:<result=[null]>

@MOONSakura0614
Copy link
Contributor Author

fixed. Thank you for pointing the bug.

@luchunliang luchunliang merged commit fa276c3 into apache:master Oct 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][SDK] Transform SQL support UrlEncode & UrlDecode functions
5 participants