Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10883][SDK] Transform SQL support InitCap function #10892

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

MOONSakura0614
Copy link
Contributor

Fixes #10883

Motivation

Add a function class: InitCapFunction and its unit test.

  • initcap(string)
    Returns a new form of STRING with the first character of each word converted to uppercase and the rest characters to lowercase. Here a word means a sequences of alphanumeric characters.

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MOONSakura0614, thank you for submitting a PR to InLong 💖 We will respond as soon as possible ⏳
This seems to be your first PR 🌠 Please be sure to follow our Contribution Guidelines.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍

aloyszhang
aloyszhang previously approved these changes Aug 26, 2024
luchunliang
luchunliang previously approved these changes Aug 27, 2024
@aloyszhang
Copy link
Contributor

plz rebase the master to resolve the conflict

@luchunliang luchunliang dismissed stale reviews from aloyszhang and themself via 1b006e2 August 27, 2024 09:08
@dockerzhang
Copy link
Contributor

@MOONSakura0614 please fix the conflicts and failed workflows.

@MOONSakura0614
Copy link
Contributor Author

@MOONSakura0614 please fix the conflicts and failed workflows.

already resolve the conflicts and force push.
Your careful review is much appreciated.

@MOONSakura0614
Copy link
Contributor Author

plz rebase the master to resolve the conflict

done and thank you for checking again.

luchunliang
luchunliang previously approved these changes Sep 3, 2024
@dockerzhang
Copy link
Contributor

@MOONSakura0614 please fix the conflicts and failed workflows.

@MOONSakura0614
Copy link
Contributor Author

@MOONSakura0614 please fix the conflicts and failed workflows.

already fix the conflicts and failed workflows by force-push.

aloyszhang
aloyszhang previously approved these changes Sep 22, 2024
@MOONSakura0614
Copy link
Contributor Author

@aloyszhang Sorry for another review. Because I forget the pr "return "" if param string is null", I expected "result = null" in unit test which caused failure.
Thank you for your kind checking~

luchunliang
luchunliang previously approved these changes Sep 26, 2024
@aloyszhang
Copy link
Contributor

You should rebase the master branch and then force push you branch

@MOONSakura0614
Copy link
Contributor Author

You should rebase the master branch and then force push you branch

solved

@luchunliang luchunliang merged commit 3da5447 into apache:master Oct 11, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][SDK] Transform SQL support InitCap function
5 participants