-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-10883][SDK] Transform SQL support InitCap function #10892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @MOONSakura0614, thank you for submitting a PR to InLong 💖 We will respond as soon as possible ⏳
This seems to be your first PR 🌠 Please be sure to follow our Contribution Guidelines.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍
plz rebase the master to resolve the conflict |
@MOONSakura0614 please fix the conflicts and failed workflows. |
86f2de1
to
d24df0b
Compare
already resolve the conflicts and force push. |
done and thank you for checking again. |
@MOONSakura0614 please fix the conflicts and failed workflows. |
3be949f
to
de5d6a6
Compare
already fix the conflicts and failed workflows by force-push. |
@aloyszhang Sorry for another review. Because I forget the pr "return "" if param string is null", I expected "result = null" in unit test which caused failure. |
You should rebase the master branch and then force push you branch |
21c380f
to
7a7dbc8
Compare
solved |
Fixes #10883
Motivation
Add a function class: InitCapFunction and its unit test.
Returns a new form of STRING with the first character of each word converted to uppercase and the rest characters to lowercase. Here a word means a sequences of alphanumeric characters.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation