[INLONG-10152][Sort] Refactor MetricOption code structure. #10156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vernedeng
reviewed
May 8, 2024
inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/metric/MetricOption.java
Outdated
Show resolved
Hide resolved
XiaoYou201
changed the title
EMsnap
reviewed
May 9, 2024
inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/metric/MetricOption.java
Outdated
Show resolved
Hide resolved
EMsnap
reviewed
May 9, 2024
inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/metric/MetricOption.java
Outdated
Show resolved
Hide resolved
EMsnap
approved these changes
May 9, 2024
dockerzhang
approved these changes
May 9, 2024
dockerzhang
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
[INLONG-10152][Sort] Refactor MetricOption code structure.
Fixes [Improve][Sort] Refactor MetricOption code structure. #10152
Motivation
The MetricOption constructor Does not conform to the single responsibility design pattern，check arguments not exist in constructor will make code clearly.
Modifications
Adjust constructor and move check arguments code statement.