fix: when fuzzy match enabled, strong correlation data first

apache · Oct 16, 2024 · e1bf653 · e1bf653
1 parent 6d3cb4f
commit e1bf653
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/...ain/java/org/apache/inlong/manager/service/transform/TransformFunctionDocServiceImpl.java b/...ain/java/org/apache/inlong/manager/service/transform/TransformFunctionDocServiceImpl.java
@@ -28,6 +28,7 @@
 import org.slf4j.LoggerFactory;
 import org.springframework.stereotype.Service;
 
+import java.util.Comparator;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
@@ -44,7 +45,7 @@ public class TransformFunctionDocServiceImpl implements TransformFunctionDocServ
 
     private final FuzzyScore fuzzyScore = new FuzzyScore(Locale.ENGLISH);
 
-    private static final int FUZZY_THRESHOLD = 3;
+    private static final int FUZZY_THRESHOLD = 5;
 
     @Override
     public PageResult<TransformFunctionDocResponse> listByCondition(TransformFunctionDocRequest request) {
@@ -74,6 +75,12 @@ private List<FunctionInfo> filterFunctionInfos(String type, String name, boolean
                         .map(n -> fuzzyMatch ? isFuzzyMatch(n, functionInfo.getFunctionName())
                                 : functionInfo.getFunctionName().toLowerCase().contains(n.toLowerCase()))
                         .orElse(true))
+                .collect(Collectors.toList()).stream()
+                .sorted(fuzzyMatch ?
+                // strong correlation data first
+                        Comparator.comparingInt((FunctionInfo f) -> fuzzyScore.fuzzyScore(f.getFunctionName(), name))
+                                .reversed()
+                        : Comparator.comparing(FunctionInfo::getFunctionName))
                 .collect(Collectors.toList());
     }
 

diff --git a/...est/java/org/apache/inlong/manager/service/transform/TransformFunctionDocServiceTest.java b/...est/java/org/apache/inlong/manager/service/transform/TransformFunctionDocServiceTest.java
@@ -120,13 +120,10 @@ public void testTransformFunctionDocByName() {
     @Test
     public void testTransformFunctionDocByNameFuzzy() {
         TransformFunctionDocRequest request = new TransformFunctionDocRequest();
-        request.setType(FunctionConstant.JSON_TYPE);
-
         // wrong function name
         request.setName("json_aray");
 
         PageResult<TransformFunctionDocResponse> functionDocs = transformFunctionDocService.listByCondition(request);
-
         Assertions.assertFalse(functionDocs.getList().isEmpty());
     }