-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kie-kogito-examples-2041] [sonataflow] Implement a getting started example for operator use case #2042
base: main
Are you sure you want to change the base?
Conversation
4f8818d
to
6c944d6
Compare
…rator use case Adds example to serverless-operator-examples, that explains basic use cases of workflow plugin CLI and showcases how to run, deploy and deploy with custom configuration on local environment or remote cluster env.
6c944d6
to
46755ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great content @domhanak !
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Outdated
Show resolved
Hide resolved
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Show resolved
Hide resolved
Co-authored-by: Gonzalo Muñoz <[email protected]>
…tfact/README.md Co-authored-by: Gonzalo Muñoz <[email protected]>
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some nitpicks, very nice example.
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Show resolved
Hide resolved
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Outdated
Show resolved
Hide resolved
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Show resolved
Hide resolved
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Show resolved
Hide resolved
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Show resolved
Hide resolved
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Outdated
Show resolved
Hide resolved
serverless-operator-examples/serverless-workflow-get-random-catfact/workflow.sw.json
Outdated
Show resolved
Hide resolved
serverless-operator-examples/serverless-workflow-get-random-catfact/workflow.sw.json
Outdated
Show resolved
Hide resolved
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #2042 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-2042/8/display/redirect Test results:
Those are the test failures: org.kie.kogito.examples.quarkus.GrafanaDockerComposeIT.testGrafanaDashboards1 expectation failed.JSON path title doesn't match. Expected: a collection containing "dmn-drools-quarkus-metrics_999-SNAPSHOT - hello - Operational Dashboard" Actual: <[dmn-drools-quarkus-metrics_999-SNAPSHOT - Custom - Operational Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - LoanEligibility - Domain Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - LoanEligibility - Operational Dashboard]> org.acme.travel.tests.multimessaging.quarkus.MultiMessagingIT.testProcessjava.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.testcontainers.quarkus.KafkaQuarkusTestResource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems great! But one nitpick I'd add is to convert the JSON files to YAML. We will give preference to YAML in the following DSL. It would be nice to start exercising this preference.
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Show resolved
Hide resolved
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Outdated
Show resolved
Hide resolved
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Show resolved
Hide resolved
serverless-operator-examples/serverless-workflow-get-random-catfact/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@domhanak Please see apache/incubator-kie-tools#2755
@tiagobento I don't believe the team has made a decision with that move. |
@wmedvede No... I didn't think it was necessary given the way our builds are currently structured. Moving the SonataFlow Operator examples to |
@tiagobento I think that move is under discussion here: https://lists.apache.org/thread/qc9vhod96mdoppo5ssj4f0pkqhzt4ghd as part of how to release them. |
@wmedvede Right... I'm seeing this discussion much more as a generic discussion talking about ALL examples, and the scope of disagreement being mostly targeted towards examples that only depend on the engines, runtimes, and everything coming from drools, optaplanner, kogito-runtimes, and kogito-apps. Since the SonataFlow Operator is already permanently inside KIE Tools, I figured this was an obvious move to do to make everyone's life easier. Yours included. Being realistic, Having You've been contributing to Let me know what I'm missing and how moving the SonataFlow Operator examples to |
@tiagobento there are many people not in favor of the move, so I think no decision is made. |
@wmedvede Great conversation! :) |
This example does not require anything to be built. |
Adds example to serverless-operator-examples, that explains basic use cases of workflow plugin CLI and showcases how to run, deploy and deploy with custom configuration on local environment or remote cluster env.