[incubator-kie-issues#1596] Adding Business Calendar Example #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Abhitocode Thanks for the PR! Some comments:
|
Abhitocode
changed the title
gitgabrio
reviewed
Nov 4, 2024
...kus-examples/process-business-calendar-example/src/main/resources/org/application.properties
Outdated
Show resolved
Hide resolved
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #2031 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-2031/5/display/redirect Test results:
Those are the test failures: org.kie.kogito.examples.OrdersProcessIT.testOrderProcessWithErrorProcess instance with id 7a6449f6-7784-445c-b8d4-a2d0e58a1842 failed becuase of Process instance with id 7a6449f6-7784-445c-b8d4-a2d0e58a1842 failed becuase of [demo.orders:7a6449f6-7784-445c-b8d4-a2d0e58a1842 - Dump order:[uuid=_0617D7DF-047A-4EC4-85E7-E201D640F4F5]] -- Cannot invoke "String.toUpperCase()" because "" is nullorg.kie.kogito.examples.OrdersRestIT.testOrdersWithErrorRest1 expectation failed.JSON path [0].id doesn't match. Expected: is "57e0a65a-6b46-4be2-a618-4722b2cf531c" Actual: null org.kie.kogito.examples.demo.OrdersProcessIT.testOrderProcessWithErrorProcess instance with id bae56bf0-7a4d-4602-a8a5-44c6b1905afd failed becuase of Process instance with id bae56bf0-7a4d-4602-a8a5-44c6b1905afd failed becuase of [demo.orders:bae56bf0-7a4d-4602-a8a5-44c6b1905afd - Dump order:[uuid=_0617D7DF-047A-4EC4-85E7-E201D640F4F5]] -- Cannot invoke "String.toUpperCase()" because "approver" is nullorg.kie.kogito.examples.demo.OrdersRestIT.testOrdersWithErrorRest1 expectation failed.JSON path [0].id doesn't match. Expected: is "f698f2ae-0910-4b29-9473-4d3a9f6027a3" Actual: null |
yesamer
reviewed
Nov 5, 2024
| business.start.hour=0 | ||
| business.holiday.date.format=yyyy-MM-dd | ||
| business.days.per.week =7 | ||
| business.cal.timezone= system default timezone.. |
There was a problem hiding this comment.
@Abhitocode I guess this property should be commented on, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1596
Add an example ensuring business calendar functionality to kogito-quarkus-examples.
The example should include a simple process that uses a business calendar. The example should contain a good README with clear step by step instructions, and has to incorporate all supporting resources required. The priority would be having this example for Quarkus.
Note: PR still in progress, files needs to be updated.