Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignite-22197 Move ifExists flag handling inside a Catalog #5121

Merged
merged 16 commits into from
Jan 30, 2025
Merged

ignite-22197 Move ifExists flag handling inside a Catalog #5121

merged 16 commits into from
Jan 30, 2025

Conversation

ygerzhedovich
Copy link
Contributor

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@joooger
ignite-22197 fix tests
3237b92
@joooger
Merge branch 'main' into ignite-22197
1d21bab 
# Conflicts:
#	modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManager.java
#	modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java
#	modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogIndexTest.java
#	modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerDescriptorCausalityTokenTest.java
#	modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogTableTest.java
#	modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogZoneTest.java
@joooger
ignite-22197 fixes after merge
bc9d3fb
@joooger
Merge branch 'main' into ignite-22197
555254c 
# Conflicts:
#	modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java
#	modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AlterZoneCommand.java
#	modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AlterZoneSetDefaultCommand.java
#	modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/DropZoneCommand.java
#	modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/RenameZoneCommand.java
#	modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java
xtern
xtern reviewed Jan 30, 2025
View reviewed changes
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogApplyResult.java Outdated Show resolved Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogApplyResult.java Outdated Show resolved Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogApplyResult.java Outdated Show resolved Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogApplyResult.java Outdated Show resolved Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogApplyResult.java Outdated Show resolved Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogApplyResult.java Outdated Show resolved Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java Outdated Show resolved Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java Outdated Show resolved Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java Show resolved Hide resolved
@ygerzhedovich ygerzhedovich merged commit a290127 into apache:main Jan 30, 2025
1 check passed
@ygerzhedovich ygerzhedovich deleted the ignite-22197 branch January 30, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korlov42 korlov42 korlov42 approved these changes

@xtern xtern xtern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ygerzhedovich @xtern @korlov42 @joooger