Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle as-of timestamp for excluding file groups #268

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

xushiyan
Copy link
Member

Description

When getting excluding file groups, it should consider the as-of timestamp if provided.

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added the bug Something isn't working label Jan 27, 2025
@xushiyan xushiyan added this to the release-0.3.0 milestone Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (88f9f03) to head (7af068c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   90.96%   91.02%   +0.05%     
==========================================
  Files          41       41              
  Lines        2037     2050      +13     
==========================================
+ Hits         1853     1866      +13     
  Misses        184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan merged commit 884a7f8 into apache:main Jan 27, 2025
11 checks passed
@xushiyan xushiyan deleted the fix-get-excluded-fg branch January 27, 2025 03:58
@xushiyan xushiyan mentioned this pull request Jan 30, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant