Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use object_store for common storage APIs #25

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

xushiyan
Copy link
Member

Fixes #24

@xushiyan xushiyan added this to the release-0.1.0 milestone Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 87.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.82%. Comparing base (0d71bd7) to head (5c2faea).

Current head 5c2faea differs from pull request most recent head c841b91

Please upload reports for the commit c841b91 to get more accurate results.

Files Patch % Lines
crates/core/src/storage/mod.rs 81.81% 10 Missing ⚠️
crates/core/src/table/fs_view.rs 92.68% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   69.85%   71.82%   +1.97%     
==========================================
  Files          13       14       +1     
  Lines         345      394      +49     
==========================================
+ Hits          241      283      +42     
- Misses        104      111       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan merged commit d84854c into apache:main Jun 21, 2024
4 checks passed
@xushiyan xushiyan deleted the use-object-store branch June 21, 2024 22:28
@xushiyan xushiyan mentioned this pull request Jul 12, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt object_store as the common storage client for local and cloud stores
1 participant