-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support customized JMX monitoring through the Factory Pattern. #2932
[Feature] Support customized JMX monitoring through the Factory Pattern. #2932
Conversation
…ure_JmxCustomization
@zhangshenghang hi, you were right before, the way MBeans are accessed can vary between different Kafka versions. throuth this customization change that can accommodate these differences, but using the generic template could make this challenging. |
thanks , @doveLin0818 If users are used to modify the script, I think it is very cumbersome. Can we add a configuration option for different versions to select our monitoring version when creating a link? Of course, this is just an example. Is there a better implementation plan according to the actual situation? @tomsun28 Do you have any suggestions? |
hi @zhangshenghang @tomsun28 ,Indeed, it is unfriendly to let users modify the scripts themselves. So this precisely reflects the advantage of this update iteration in scalability. |
Hi 👍+1,I think this is a good solution for different versions of Kafka. For others app type different version, how about consider use the different template yml. We will build a template market later, and users can find the required version yml from the public market to download and use. The system defaults provide a common version yml. |
+1 👍 ,I will review the code. |
…eature_JmxCustomization
@doveLin0818 Hi, After making the changes above, remember to click resolve |
Hello @zhangshenghang ,Happy new year,the code has been written successfully, but I don't seem to see the comment of code review, and I can't find the entry of 'resolve' |
What's changed?
Original Kafka monitoring indicators:
Now Kafka monitoring indicators:
Checklist
Add or update API