[feature] integrate with Apache Arrow #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 2888 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1491 | 2 | 1395 | 0 |
Click to see the invalid file list
- hertzbeat-collector/hertzbeat-collector-common/src/main/java/org/apache/hertzbeat/collector/collect/common/MetricsDataBuilder.java
- hertzbeat-common/src/main/java/org/apache/hertzbeat/common/entity/message/CollectRep.java
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
| @@ -0,0 +1,23 @@ | |||
| package org.apache.hertzbeat.collector.collect.common; | |||
There was a problem hiding this comment.
Suggested change
| package org.apache.hertzbeat.collector.collect.common; | |
| /* | |
| * Licensed to the Apache Software Foundation (ASF) under one | |
| * or more contributor license agreements. See the NOTICE file | |
| * distributed with this work for additional information | |
| * regarding copyright ownership. The ASF licenses this file | |
| * to you under the Apache License, Version 2.0 (the | |
| * "License"); you may not use this file except in compliance | |
| * with the License. You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, | |
| * software distributed under the License is distributed on an | |
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | |
| * KIND, either express or implied. See the License for the | |
| * specific language governing permissions and limitations | |
| * under the License. | |
| */ | |
| package org.apache.hertzbeat.collector.collect.common; |
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| // Generated by the protocol buffer compiler. DO NOT EDIT! |
There was a problem hiding this comment.
Suggested change
| // Generated by the protocol buffer compiler. DO NOT EDIT! | |
| /* | |
| * Licensed to the Apache Software Foundation (ASF) under one | |
| * or more contributor license agreements. See the NOTICE file | |
| * distributed with this work for additional information | |
| * regarding copyright ownership. The ASF licenses this file | |
| * to you under the Apache License, Version 2.0 (the | |
| * "License"); you may not use this file except in compliance | |
| * with the License. You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, | |
| * software distributed under the License is distributed on an | |
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | |
| * KIND, either express or implied. See the License for the | |
| * specific language governing permissions and limitations | |
| * under the License. | |
| */ | |
| // Generated by the protocol buffer compiler. DO NOT EDIT! |
| @@ -0,0 +1,23 @@ | |||
| package org.apache.hertzbeat.collector.collect.common; | |||
There was a problem hiding this comment.
Suggested change
| package org.apache.hertzbeat.collector.collect.common; | |
| /* | |
| * Licensed to the Apache Software Foundation (ASF) under one | |
| * or more contributor license agreements. See the NOTICE file | |
| * distributed with this work for additional information | |
| * regarding copyright ownership. The ASF licenses this file | |
| * to you under the Apache License, Version 2.0 (the | |
| * "License"); you may not use this file except in compliance | |
| * with the License. You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, | |
| * software distributed under the License is distributed on an | |
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | |
| * KIND, either express or implied. See the License for the | |
| * specific language governing permissions and limitations | |
| * under the License. | |
| */ | |
| package org.apache.hertzbeat.collector.collect.common; |
| @@ -20,4411 +1,1802 @@ | |||
| // Generated by the protocol buffer compiler. DO NOT EDIT! | |||
There was a problem hiding this comment.
Suggested change
| // Generated by the protocol buffer compiler. DO NOT EDIT! | |
| /* | |
| * Licensed to the Apache Software Foundation (ASF) under one | |
| * or more contributor license agreements. See the NOTICE file | |
| * distributed with this work for additional information | |
| * regarding copyright ownership. The ASF licenses this file | |
| * to you under the Apache License, Version 2.0 (the | |
| * "License"); you may not use this file except in compliance | |
| * with the License. You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, | |
| * software distributed under the License is distributed on an | |
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | |
| * KIND, either express or implied. See the License for the | |
| * specific language governing permissions and limitations | |
| * under the License. | |
| */ | |
| // Generated by the protocol buffer compiler. DO NOT EDIT! |
Calvin979
changed the title
|
👍👍 great! i need more time to review🤭 |
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: shown <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
There was a problem hiding this comment.
license-eye has checked 2892 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1494 | 3 | 1395 | 0 |
Click to see the invalid file list
- hertzbeat-common/src/main/java/org/apache/arrow/vector/table/ArrowTable.java
- hertzbeat-common/src/main/java/org/apache/hertzbeat/common/serialize/RedisMetricsDataCodec.java
- hertzbeat-common/src/test/java/org/apache/arrow/vector/table/ArrowTableTest.java
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
| @@ -0,0 +1,90 @@ | |||
| package org.apache.arrow.vector.table; | |||
There was a problem hiding this comment.
Suggested change
| package org.apache.arrow.vector.table; | |
| /* | |
| * Licensed to the Apache Software Foundation (ASF) under one | |
| * or more contributor license agreements. See the NOTICE file | |
| * distributed with this work for additional information | |
| * regarding copyright ownership. The ASF licenses this file | |
| * to you under the Apache License, Version 2.0 (the | |
| * "License"); you may not use this file except in compliance | |
| * with the License. You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, | |
| * software distributed under the License is distributed on an | |
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | |
| * KIND, either express or implied. See the License for the | |
| * specific language governing permissions and limitations | |
| * under the License. | |
| */ | |
| package org.apache.arrow.vector.table; |
| @@ -0,0 +1,90 @@ | |||
| package org.apache.arrow.vector.table; | |||
There was a problem hiding this comment.
Suggested change
| package org.apache.arrow.vector.table; | |
| /* | |
| * Licensed to the Apache Software Foundation (ASF) under one | |
| * or more contributor license agreements. See the NOTICE file | |
| * distributed with this work for additional information | |
| * regarding copyright ownership. The ASF licenses this file | |
| * to you under the Apache License, Version 2.0 (the | |
| * "License"); you may not use this file except in compliance | |
| * with the License. You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, | |
| * software distributed under the License is distributed on an | |
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | |
| * KIND, either express or implied. See the License for the | |
| * specific language governing permissions and limitations | |
| * under the License. | |
| */ | |
| package org.apache.arrow.vector.table; |
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
Signed-off-by: tomsun28 <[email protected]>
tomsun28
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Relate to: #2825
How to test?
--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMEDOperations in Apache Arrow
Please refer package: org.apache.hertzbeat.common.entity.arrow
I've organized operations and data structure about arrow.
org.apache.hertzbeat.common.entity.arrow.ArrowVectorWriter: used for writing data and tranferring to bytes arr, which can be set incollect_rep.proto.org.apache.hertzbeat.common.entity.arrow.ArrowVectorReader: used for reading bytes arr that created by ArrowVectorWriterorg.apache.hertzbeat.common.entity.arrow.RowWrapperandorg.apache.hertzbeat.common.entity.arrow.ArrowCell: when try to read data from ArrowVectorReader, we can get this two data structure.Checklist
Add or update API