-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve]add Plc protocol , Modbus monitor #2850
Conversation
[improve] fix PlcCollectImpl check-license-header error [improve] fix PlcCollectImpl check markdown
[improve] fix ModBus check markdown and License check
[improve] fix app-nebulaGraph.yml dead links found [improve] fix app-nebulaGraph.yml dead links found to app-nebula_graph.yml
I found that pltConnectivity close() takes a long time, mostly 2000ms, and may need to be optimized by reusing connections or asynchronously closing connections |
I have a question, does Modbus frequently disconnect after each data acquisition, or should the connection be maintained If we need to maintain the connection continuously, I have a suggestion to create a class specifically for managing the connection, and then initialize the background thread in it to determine whether the monitoring where the current connection is located is still in the startup state. If it is disabled, disconnect the connection. I don't know if this idea is correct |
Maybe it should be left to the user to choose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem with the code
What's changed?
The plc4x project is used to implement the collection of PLC protocol. Currently, the retention register and coil collection of modBus protocol have been introduced, which can collect data from different slave devices with the same IP address
Checklist
Add or update API