Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add Apache SystemDS as related to using Hadoop #33

Open
wants to merge 2 commits into
base: asf-site
Choose a base branch
from

Conversation

j143
Copy link

@j143 j143 commented Dec 16, 2021

Hi!

We would like to add https://systemds.apache.org/ to this homepage.
We use hadoop as backend.

Thanks

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @j143, thank you for your patch.

Would you update https://github.com/apache/hadoop-site/blob/asf-site/src/related.md and generate the index.html by running hugo?

@j143
Copy link
Author

j143 commented Jan 10, 2022

Hi @aajisaka , thanks for prelim review. I took the liberty to update the copyright year (Hopefully that is okay?)

Also, why is it content/news/2021-12-17-log4jshell.html while the src/news/2021-12-17-log4shell.md?

@j143 j143 requested a review from aajisaka January 10, 2022 18:51
@aajisaka
Copy link
Member

I took the liberty to update the copyright year (Hopefully that is okay?)

Let's do this in a separate PR.

why is it content/news/2021-12-17-log4jshell.html while the src/news/2021-12-17-log4shell.md?

What do you mean?

@j143
Copy link
Author

j143 commented Jan 17, 2022

Let's do this in a separate PR.

sure.

The log4jshell word is differently mentioned.

- log4shell
+ log4jshell

@aajisaka
Copy link
Member

The log4jshell word is differently mentioned.

Thank you. First it was log4jshell and then corrected to log4shell in fd61eb2. However, the fix was not complete.

@aajisaka
Copy link
Member

I'll correct to log4shell in a separate commit.

@aajisaka
Copy link
Member

Fixed the path of the page. 90aa81e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants