Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5932] improve(CLI): Fix the CLI delete the anonymous user #6359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abyss-lord
Copy link
Contributor

What changes were proposed in this pull request?

Fix the CLI delete the anonymous user

Why are the changes needed?

Fix: #5932

Does this PR introduce any user-facing change?

(Please list the user-facing changes introduced by your change, including

  1. Change in user-facing APIs.
  2. Addition or removal of property keys.)

How was this patch tested?

local test

gcli user delete -m demo_metalake --user anonymous
# Are you sure you want to delete the anonymous user? This will cause unexpected behavior.
# N

@Abyss-lord
Copy link
Contributor Author

Hi @justinmclean @tengqm , could you please review this PR when you have time? I’d really appreciate your feedback.

@tengqm
Copy link
Contributor

tengqm commented Jan 23, 2025

Sorry, I don't get the merit of this change.

@justinmclean
Copy link
Member

If you delete the anonymous user, all sorts of things could happen. This is to warn users that they probably don't want to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] In the Gravitino CLI/Java API you can delete the anoymous user
3 participants