[#4209] chore replace hardcoded value with std definition #6354
Conversation
zzzk1
changed the title
| return new String(bb.array(), bb.arrayOffset() + bb.position(), bb.remaining(), "UTF-8"); | ||
| } catch (UnsupportedEncodingException e) { | ||
| throw new IllegalCharsetNameException("UTF-8"); // won't happen. | ||
| } |
There was a problem hiding this comment.
Why did you remove this code?
There was a problem hiding this comment.
Why did you remove this code?
The String constructor used here does not declare that it throws an UnsupportedEncodingException because StandardCharsets.UTF_8 guarantees that the encoding is supported. However, an IndexOutOfBoundsException could occur in this context.
There was a problem hiding this comment.
That seems Ok, but I assume it was there for some reason for it originally, so it may not be best to remove it.
There was a problem hiding this comment.
That seems Ok, but I assume it was there for some reason for it originally, so it may not be best to remove it.
we can't do that, if we use:
try {
return new String(bb.array(), bb.arrayOffset() + bb.position(), bb.remaining(), StandardCharsets.UTF_8);
} catch (UnsupportedEncodingException e) {
throw new IllegalCharsetNameException("UTF-8"); // won't happen.
}the complier will report Exception java.io.UnsupportedEncodingException is never thrown in the corresponding try block like this:
maybe we can use Exception replace UnsupportedEncodingException?
|
We use Spotless to ensure our code is consistently formatted. You'll need to run |
|
Can you please update the PR description like other PRs? |
yes |
What changes were proposed in this pull request?
Use standard definition lib value to replace the hardcoded value: UTF-8.
Why are the changes needed?
Fix: #4209
Does this PR introduce any user-facing change?
no
How was this patch tested?
no