Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spark-connector):support JDBC catalog #6212

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(spark-connector):support JDBC catalog #6212

wants to merge 9 commits into from

Conversation

liangyouze
Copy link
Contributor

@liangyouze liangyouze commented Jan 13, 2025 •
edited
Loading

What changes were proposed in this pull request?

Support JDBC catalog in Spark Connector

Why are the changes needed?

Fix: #1572 #6164

Does this PR introduce any user-facing change?

no

How was this patch tested?

TestJdbcPropertiesConverter
SparkJdbcCatalogIT

@FANNG1
Copy link
Contributor

FANNG1 commented Jan 13, 2025

Thanks for your PR, could you add corresponding IT? You could refer to SparkHiveCatalogIT

@liangyouze
add integeration test
72e0ead 
add integeration test
@shaofengshi
Copy link
Contributor

The code looks clean; looking forward to have it.

@liangyouze liangyouze force-pushed the spark-jdbc branch 2 times, most recently from 5ffe3bb to d07200c Compare January 23, 2025 01:49
@FANNG1
Copy link
Contributor

FANNG1 commented Jan 23, 2025

LGTM, except minor comments

FANNG1
FANNG1 reviewed Jan 23, 2025
View reviewed changes
...k-common/src/test/java/org/apache/gravitino/spark/connector/integration/test/SparkEnvIT.java
@@ -151,6 +158,14 @@ private void initHiveEnv() {
HiveContainer.HDFS_DEFAULTFS_PORT);
}

private void initMysqlEnv() throws SQLException {
Copy link
Contributor

@FANNG1 FANNG1 Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you move this logic in SparkJdbcMysqlCatalogIT? such as create an initCatalogEnv method in SparkEnvIT, and overwrite it in SparkJdbcMysqlCatalogIT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FANNG1 FANNG1 FANNG1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Subtask] [spark-connector] support JDBC catalog
3 participants
@liangyouze @FANNG1 @shaofengshi