[#5118] feat(auth): Lakehouse Iceberg catalog supports Ranger authorization plugin #5467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunliu
reviewed
Nov 6, 2024
There was a problem hiding this comment.
The RangerIcebergE2EIT class is the same as RangerHiveE2EIT, I think we can abstract a common IT class.
There was a problem hiding this comment.
They are similar but different. For same update SQL, Iceberg will succeed but Hive will throw exception.
xunliu
reviewed
Nov 6, 2024
Comment on lines
52
to
57
| | `authorization-provider` | Providers to use to implement authorization plugin such as `ranger`. | (none) | No | 0.6.0-incubating | | ||
| | `authorization.ranger.admin.url` | The Apache Ranger web URIs. | (none) | No | 0.6.0-incubating | | ||
| | `authorization.ranger.auth.type` | The Apache Ranger authentication type `simple` or `kerberos`. | `simple` | No | 0.6.0-incubating | | ||
| | `authorization.ranger.username` | The Apache Ranger admin web login username (auth type=simple), or kerberos principal(auth type=kerberos), Need have Ranger administrator permission. | (none) | No | 0.6.0-incubating | | ||
| | `authorization.ranger.password` | The Apache Ranger admin web login user password (auth type=simple), or path of the keytab file(auth type=kerberos) | (none) | No | 0.6.0-incubating | | ||
| | `authorization.ranger.service.name` | The Apache Ranger service name. | (none) | No | 0.6.0-incubating | |
There was a problem hiding this comment.
Maybe need to change 0.6.0-incubating to 0.8.0-xxx?
There was a problem hiding this comment.
This option reuse Hive properties. I don't add a new properity. This propeties are introduced in 0.6.0-incubating. But property doesn't bind to a fixed version. If you think it's necessary, I can this version.
There was a problem hiding this comment.
Change to 0.8.0-incubating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Lakehouse Iceberg catalog supports Ranger authorization plugin
Why are the changes needed?
Fix: #5118
Does this PR introduce any user-facing change?
Add the document.
How was this patch tested?
Add E2E tests.