Skip to content
build

[#6302] refactor:Optimize Flink connector properties converter #18611

Sign in to view logs

[#6302] refactor:Optimize Flink connector properties converter

[#6302] refactor:Optimize Flink connector properties converter #18611

Triggered via pull request January 23, 2025 14:26
@sunxiaojiansunxiaojian
synchronize #6303
sunxiaojian:extract-flink-converter-logic
Status Failure
Total duration 2m 34s
Artifacts –

build.yml

on: pull_request
changes
5s
changes
compile-check
0s
compile-check
spark-connector-build
0s
spark-connector-build
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

8 errors and 3 warnings
build (8): task ':flink-connector:flink:spotlessJavaCheck'#L1
Execution failed for task ':flink-connector:flink:spotlessJavaCheck': The following files had format violations: src/main/java/org/apache/gravitino/flink/connector/PropertiesConverter.java @@ -50,7 +50,7 @@ ······if·(gravitinoKey·!=·null)·{ ········gravitinoProperties.put(gravitinoKey,·entry.getValue()); ······}·else·if·(!entry.getKey().startsWith(FLINK_PROPERTY_PREFIX))·{ -········gravitinoProperties.put(FLINK_PROPERTY_PREFIX+entry.getKey(),·entry.getValue()); +········gravitinoProperties.put(FLINK_PROPERTY_PREFIX·+·entry.getKey(),·entry.getValue()); ······}·else·{ ········gravitinoProperties.put(entry.getKey(),·entry.getValue()); ······} src/test/java/org/apache/gravitino/flink/connector/hive/TestHivePropertiesConverter.java @@ -33,38 +33,38 @@ ··@test ··public·void·testToGravitinoCatalogProperties()·{ ····Configuration·configuration·= -············Configuration.fromMap( -····················ImmutableMap.of( -····························"hive-conf-dir", -····························"src/test/resources/flink-tests", -····························"flink.bypass.key", -····························"value", -····························HiveConf.ConfVars.METASTOREURIS.varname, -····························"thrift://127.0.0.1:9084")); +········Configuration.fromMap( +············ImmutableMap.of( +················"hive-conf-dir", +················"src/test/resources/flink-tests", +················"flink.bypass.key", +················"value", +················HiveConf.ConfVars.METASTOREURIS.varname, +················"thrift://127.0.0.1:9084")); ····Map<String,·String>·properties·=·CONVERTER.toGravitinoCatalogProperties(configuration); ····Assertions.assertEquals(3,·properties.size()); ····Assertions.assertEquals( -············"src/test/resources/flink-tests", -············properties.get("flink.bypass.hive-conf-dir"), -············"This·will·add·the·prefix"); +········"src/test/resources/flink-tests", +········properties.get("flink.bypass.hive-conf-dir"), +········"This·will·add·the·prefix"); ····Assertions.assertEquals( -············"value",·properties.get("flink.bypass.key"),·"The·prefix·have·already·existed"); +········"value",·properties.get("flink.bypass.key"),·"The·prefix·have·already·existed"); ····Assertions.assertEquals( -············"thrift://127.0.0.1:9084", -············properties.get(HiveConstants.METASTORE_URIS), -············"The·key·is·converted·to·Gravitino·Config"); +········"thrift://127.0.0.1:9084", +········properties.get(HiveConstants.METASTORE_URIS), +········"The·key·is·converted·to·Gravitino·Config"); ... (19 more lines that didn't fit) Violations also present in: src/test/java/org/apache/gravitino/flink/connector/integration/test/hive/FlinkHiveCatalogIT.java src/test/java/org/apache/gravitino/flink/connector/integration/test/iceberg/FlinkIcebergCatalogIT.java src/test/java/org/apache/gravitino/flink/connector/integration/test/paimon/FlinkPaimonCatalogIT.java src/test/java/org/apache/gravitino/flink/connector/paimon/TestPaimonPropertiesConverter.java Run './gradlew :flink-connector:flink:spotlessApply' to fix these violations. at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:111) at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:53) at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125) at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExe
build (8)
Process completed with exit code 1.
build (11)
The job was canceled because "_8" failed.
build (11): task ':flink-connector:flink:spotlessJavaCheck'#L1
Execution failed for task ':flink-connector:flink:spotlessJavaCheck': The following files had format violations: src/main/java/org/apache/gravitino/flink/connector/PropertiesConverter.java @@ -50,7 +50,7 @@ ······if·(gravitinoKey·!=·null)·{ ········gravitinoProperties.put(gravitinoKey,·entry.getValue()); ······}·else·if·(!entry.getKey().startsWith(FLINK_PROPERTY_PREFIX))·{ -········gravitinoProperties.put(FLINK_PROPERTY_PREFIX+entry.getKey(),·entry.getValue()); +········gravitinoProperties.put(FLINK_PROPERTY_PREFIX·+·entry.getKey(),·entry.getValue()); ······}·else·{ ········gravitinoProperties.put(entry.getKey(),·entry.getValue()); ······} src/test/java/org/apache/gravitino/flink/connector/hive/TestHivePropertiesConverter.java @@ -33,38 +33,38 @@ ··@test ··public·void·testToGravitinoCatalogProperties()·{ ····Configuration·configuration·= -············Configuration.fromMap( -····················ImmutableMap.of( -····························"hive-conf-dir", -····························"src/test/resources/flink-tests", -····························"flink.bypass.key", -····························"value", -····························HiveConf.ConfVars.METASTOREURIS.varname, -····························"thrift://127.0.0.1:9084")); +········Configuration.fromMap( +············ImmutableMap.of( +················"hive-conf-dir", +················"src/test/resources/flink-tests", +················"flink.bypass.key", +················"value", +················HiveConf.ConfVars.METASTOREURIS.varname, +················"thrift://127.0.0.1:9084")); ····Map<String,·String>·properties·=·CONVERTER.toGravitinoCatalogProperties(configuration); ····Assertions.assertEquals(3,·properties.size()); ····Assertions.assertEquals( -············"src/test/resources/flink-tests", -············properties.get("flink.bypass.hive-conf-dir"), -············"This·will·add·the·prefix"); +········"src/test/resources/flink-tests", +········properties.get("flink.bypass.hive-conf-dir"), +········"This·will·add·the·prefix"); ····Assertions.assertEquals( -············"value",·properties.get("flink.bypass.key"),·"The·prefix·have·already·existed"); +········"value",·properties.get("flink.bypass.key"),·"The·prefix·have·already·existed"); ····Assertions.assertEquals( -············"thrift://127.0.0.1:9084", -············properties.get(HiveConstants.METASTORE_URIS), -············"The·key·is·converted·to·Gravitino·Config"); +········"thrift://127.0.0.1:9084", +········properties.get(HiveConstants.METASTORE_URIS), +········"The·key·is·converted·to·Gravitino·Config"); ... (19 more lines that didn't fit) Violations also present in: src/test/java/org/apache/gravitino/flink/connector/integration/test/hive/FlinkHiveCatalogIT.java src/test/java/org/apache/gravitino/flink/connector/integration/test/iceberg/FlinkIcebergCatalogIT.java src/test/java/org/apache/gravitino/flink/connector/integration/test/paimon/FlinkPaimonCatalogIT.java src/test/java/org/apache/gravitino/flink/connector/paimon/TestPaimonPropertiesConverter.java Run './gradlew :flink-connector:flink:spotlessApply' to fix these violations. at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:111) at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:53) at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125) at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExe
build (11)
The operation was canceled.
build (17)
The job was canceled because "_8" failed.
build (17): task ':flink-connector:flink:spotlessJavaCheck'#L1
Execution failed for task ':flink-connector:flink:spotlessJavaCheck': The following files had format violations: src/main/java/org/apache/gravitino/flink/connector/PropertiesConverter.java @@ -50,7 +50,7 @@ ······if·(gravitinoKey·!=·null)·{ ········gravitinoProperties.put(gravitinoKey,·entry.getValue()); ······}·else·if·(!entry.getKey().startsWith(FLINK_PROPERTY_PREFIX))·{ -········gravitinoProperties.put(FLINK_PROPERTY_PREFIX+entry.getKey(),·entry.getValue()); +········gravitinoProperties.put(FLINK_PROPERTY_PREFIX·+·entry.getKey(),·entry.getValue()); ······}·else·{ ········gravitinoProperties.put(entry.getKey(),·entry.getValue()); ······} src/test/java/org/apache/gravitino/flink/connector/hive/TestHivePropertiesConverter.java @@ -33,38 +33,38 @@ ··@test ··public·void·testToGravitinoCatalogProperties()·{ ····Configuration·configuration·= -············Configuration.fromMap( -····················ImmutableMap.of( -····························"hive-conf-dir", -····························"src/test/resources/flink-tests", -····························"flink.bypass.key", -····························"value", -····························HiveConf.ConfVars.METASTOREURIS.varname, -····························"thrift://127.0.0.1:9084")); +········Configuration.fromMap( +············ImmutableMap.of( +················"hive-conf-dir", +················"src/test/resources/flink-tests", +················"flink.bypass.key", +················"value", +················HiveConf.ConfVars.METASTOREURIS.varname, +················"thrift://127.0.0.1:9084")); ····Map<String,·String>·properties·=·CONVERTER.toGravitinoCatalogProperties(configuration); ····Assertions.assertEquals(3,·properties.size()); ····Assertions.assertEquals( -············"src/test/resources/flink-tests", -············properties.get("flink.bypass.hive-conf-dir"), -············"This·will·add·the·prefix"); +········"src/test/resources/flink-tests", +········properties.get("flink.bypass.hive-conf-dir"), +········"This·will·add·the·prefix"); ····Assertions.assertEquals( -············"value",·properties.get("flink.bypass.key"),·"The·prefix·have·already·existed"); +········"value",·properties.get("flink.bypass.key"),·"The·prefix·have·already·existed"); ····Assertions.assertEquals( -············"thrift://127.0.0.1:9084", -············properties.get(HiveConstants.METASTORE_URIS), -············"The·key·is·converted·to·Gravitino·Config"); +········"thrift://127.0.0.1:9084", +········properties.get(HiveConstants.METASTORE_URIS), +········"The·key·is·converted·to·Gravitino·Config"); ... (19 more lines that didn't fit) Violations also present in: src/test/java/org/apache/gravitino/flink/connector/integration/test/hive/FlinkHiveCatalogIT.java src/test/java/org/apache/gravitino/flink/connector/integration/test/iceberg/FlinkIcebergCatalogIT.java src/test/java/org/apache/gravitino/flink/connector/integration/test/paimon/FlinkPaimonCatalogIT.java src/test/java/org/apache/gravitino/flink/connector/paimon/TestPaimonPropertiesConverter.java Run './gradlew :flink-connector:flink:spotlessApply' to fix these violations. at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:111) at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:53) at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125) at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExe
build (17)
The operation was canceled.
changes
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
build (8)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
build (8)
No files were found with the provided path: build/reports catalogs/**/*.log catalogs/**/*.tar. No artifacts will be uploaded.