-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #4869] Add Webhook support for HTTP Source Connector #4913
Conversation
@Pil0tXia PTAL |
...ntmesh-connector-http/src/main/java/org/apache/eventmesh/connector/http/util/QueueUtils.java
Outdated
Show resolved
Hide resolved
...or-http/src/main/java/org/apache/eventmesh/connector/http/common/BoundedConcurrentQueue.java
Outdated
Show resolved
Hide resolved
...or-http/src/main/java/org/apache/eventmesh/connector/http/common/BoundedConcurrentQueue.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't finished reading it yet, I need to travel tomorrow and the next day. I will continue to review when I have time.
...or-http/src/main/java/org/apache/eventmesh/connector/http/common/BoundedConcurrentQueue.java
Outdated
Show resolved
Hide resolved
...-http/src/main/java/org/apache/eventmesh/connector/http/source/protocol/ProtocolFactory.java
Outdated
Show resolved
Hide resolved
No problem, open-source work is not the main focus for most people, but don't forget to continue the code review.🤪 |
...p/src/main/java/org/apache/eventmesh/connector/http/source/config/SourceConnectorConfig.java
Outdated
Show resolved
Hide resolved
...p/src/main/java/org/apache/eventmesh/connector/http/source/protocol/impl/GitHubProtocol.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/eventmesh/connector/http/source/protocol/impl/CloudEventProtocol.java
Show resolved
Hide resolved
...c/main/java/org/apache/eventmesh/connector/http/source/protocol/impl/CloudEventProtocol.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please let me know if the logical order of the information has not been submitted yet?
BTW, please resolve conflicts.
OK
First, for the GitHub protocol, I have imposed a restriction where the source can only receive either forms or JSON, but not both simultaneously. This ensures that all data is either parsed (form) or not parsed (JSON). Consequently, this should ensure that data undergoes the same processing logic, thereby maintaining the order. For the thread-safe queue, I have currently encapsulated CircularFifoQueue and made it thread-safe using the synchronized keyword. The reason for not using some convenient utility classes is that the fetchRange method is unique to the current queue, and using utility classes cannot guarantee the thread safety of this method. |
# Conflicts: # eventmesh-connectors/eventmesh-connector-http/src/main/java/org/apache/eventmesh/connector/http/source/connector/HttpSourceConnector.java
…ve code conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, LGTM.
The assignee of #4825 has already started working at a company and doesn't have time to develop this issue. I can assign this issue to you instead. Are you interested?
Although I would very much like to claim and complete this issue, I currently have other work to finish. You can try assigning it to other contributors first. If I have free time and the issue hasn't been resolved, I will claim and solve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #4869
Motivation
[Feature] Add Webhook support for HTTP Source Connector #4869
Modifications
Documentation