[ISSUE #4731] HttpRequestProcessor enhancement #4732
Conversation
| /** | ||
| * | ||
| * @return {@link Executor} | ||
| */ | ||
| Executor executor(); | ||
|
|
There was a problem hiding this comment.
It seems this method has no functional relation with HttpRequestProcessor interface. As for the current implementation of EventMesh for asynchronous requests, the executor has not been placed within the interface that handles the requests. May you please explain its design?
There was a problem hiding this comment.
Because when I was looking at the source code, I found that the HttpRequestProcessor requires a thread pool to execute, and this design can clearly know which thread pool executes the processor .
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4732 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. |
|
Conflicts need to be resolved. |
karsonto
force-pushed
the
develop-httpProcess-enhancement
branch
from
df92b6f to
da04b07
Compare
@Alonexc Please help to review again |
|
@karsonto please resolve the conflicts thanks. |
karsonto
force-pushed
the
develop-httpProcess-enhancement
branch
from
da04b07 to
7ebdf35
Compare
|
@xwm1992 ok,please review. |
.../org/apache/eventmesh/runtime/core/protocol/http/processor/AbstractHttpRequestProcessor.java
Show resolved
Hide resolved
Fixes #4731.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation