Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4683] Documentation Needed for eventmesh-connector-redis #4684

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

fabian4
Copy link
Member

@fabian4 fabian4 commented Dec 19, 2023

Fixes #4683.

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@pandaapo pandaapo changed the title [ISSUE #4683] Documentation Needed for eventmesh-connector-rabbitmq [ISSUE #4683] Documentation Needed for eventmesh-connector-redis Dec 20, 2023
@pandaapo
Copy link
Member

Could you help add a sentence "Connector runs as a standalone service by main()." here https://github.com/apache/eventmesh/tree/master/eventmesh-connectors#connector? Because I found that new users may not know how to start Connector #4600 (comment).

@fabian4 fabian4 requested a review from pandaapo December 20, 2023 16:00
@Pil0tXia
Copy link
Member

I have a small suggestion. It would be better to use RabbitMQ instead of rabbitmq, and the same applies to MongoDB and Redis.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e056d7a) 17.39% compared to head (c78abc7) 17.39%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4684   +/-   ##
=========================================
  Coverage     17.39%   17.39%           
  Complexity     1759     1759           
=========================================
  Files           797      797           
  Lines         29844    29844           
  Branches       2579     2579           
=========================================
  Hits           5192     5192           
  Misses        24171    24171           
  Partials        481      481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 1a381ed into apache:master Dec 22, 2023
13 checks passed
@fabian4 fabian4 deleted the Add_doc_for_eventmesh-connector-redis branch December 22, 2023 03:18
@xwm1992 xwm1992 added this to the 1.11.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Documentation Needed for eventmesh-connector-redis
5 participants