Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4667] Fix some connectors have not been included in the package #4669

Merged
merged 3 commits into from
Dec 17, 2023

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Dec 16, 2023

Fixes #4667

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

  • Fix Some connectors have not been included in the package

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Pil0tXia
Copy link
Member

Dependencies check failed. Please add known dependencies.

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d625790) 17.39% compared to head (20fd197) 17.39%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4669      +/-   ##
============================================
- Coverage     17.39%   17.39%   -0.01%     
+ Complexity     1760     1759       -1     
============================================
  Files           797      797              
  Lines         29795    29795              
  Branches       2578     2578              
============================================
- Hits           5184     5182       -2     
- Misses        24131    24132       +1     
- Partials        480      481       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xwm1992
xwm1992 previously approved these changes Dec 17, 2023
@@ -0,0 +1,28 @@
Copyright (c) 2012-2022 The ANTLR Project. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to know more. Is it necessary to add the corresponding LICENSE to each newly introduced jar package at the same time? What kind of LICENSE will be illegal?

我想了解一下。是每个新引入的jar包都需要同时加上对应的LICENSE吗?什么样的LICENSE将是不合法的?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to know more. Is it necessary to add the corresponding LICENSE to each newly introduced jar package at the same time? What kind of LICENSE will be illegal?

我想了解一下。是每个新引入的jar包都需要同时加上对应的LICENSE吗?什么样的LICENSE将是不合法的?

You can find the corresponding license in the documentation of the respective JAR package or in the project itself. It's not randomly written.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License specification provided by @xwm1992 : https://www.apache.org/legal/resolved.html

@pandaapo pandaapo merged commit 65fdabf into apache:master Dec 17, 2023
12 of 13 checks passed
@mxsm mxsm deleted the bug-mxsm-4667 branch January 16, 2024 15:12
@xwm1992 xwm1992 added this to the 1.11.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Some connectors have not been included in the package
4 participants