Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mac](compile) fix compile failed on mac #47014

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

cambyzju
Copy link
Contributor

pick part of #40202 to branch-3.0, to fix compile failed on mac

@Thearas
Copy link
Contributor

Thearas commented Jan 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@cambyzju
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41499 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2a430dd91d3fea297d535a054a5320c1edd904c7, data reload: false

------ Round 1 ----------------------------------
q1	17672	7719	7352	7352
q2	2079	184	170	170
q3	10661	1108	1240	1108
q4	10562	769	721	721
q5	7754	2945	2888	2888
q6	240	149	146	146
q7	991	630	614	614
q8	9371	2053	2063	2053
q9	6598	6398	6405	6398
q10	6982	2329	2325	2325
q11	465	274	265	265
q12	440	219	216	216
q13	17806	3003	3009	3003
q14	244	211	223	211
q15	578	519	517	517
q16	692	610	599	599
q17	1004	646	644	644
q18	7446	6679	6792	6679
q19	1395	1159	1066	1066
q20	493	205	208	205
q21	4170	3439	3318	3318
q22	1105	1013	1001	1001
Total cold run time: 108748 ms
Total hot run time: 41499 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7254	7244	7243	7243
q2	330	231	243	231
q3	3078	3001	2972	2972
q4	2107	1889	1785	1785
q5	5717	5762	5782	5762
q6	231	150	149	149
q7	2240	1837	1843	1837
q8	3386	3571	3523	3523
q9	8935	8989	8892	8892
q10	3602	3541	3574	3541
q11	614	519	496	496
q12	814	612	612	612
q13	10756	3192	3223	3192
q14	314	285	268	268
q15	581	538	532	532
q16	718	677	677	677
q17	1848	1668	1655	1655
q18	8302	7869	7695	7695
q19	1691	1666	1558	1558
q20	2079	1880	1868	1868
q21	5761	5404	5365	5365
q22	1114	1029	1038	1029
Total cold run time: 71472 ms
Total hot run time: 60882 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197712 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2a430dd91d3fea297d535a054a5320c1edd904c7, data reload: false

query1	1300	945	910	910
query2	6261	2156	2108	2108
query3	10870	4338	4297	4297
query4	66451	29414	23930	23930
query5	4930	461	448	448
query6	417	175	166	166
query7	5544	305	307	305
query8	306	220	226	220
query9	8914	2714	2690	2690
query10	457	274	254	254
query11	17309	15082	15758	15082
query12	164	103	106	103
query13	1473	450	434	434
query14	9846	6775	7463	6775
query15	206	177	180	177
query16	7113	489	494	489
query17	1178	590	611	590
query18	1823	323	333	323
query19	207	164	158	158
query20	114	106	114	106
query21	209	108	108	108
query22	4681	4455	4580	4455
query23	34566	34023	34174	34023
query24	6122	2878	2877	2877
query25	549	432	432	432
query26	655	174	168	168
query27	1787	361	369	361
query28	4270	2508	2461	2461
query29	702	472	463	463
query30	240	176	177	176
query31	1020	817	868	817
query32	65	58	56	56
query33	408	286	293	286
query34	923	515	529	515
query35	868	712	729	712
query36	1092	954	948	948
query37	118	67	77	67
query38	4147	4095	4119	4095
query39	1548	1657	1446	1446
query40	205	101	101	101
query41	49	49	50	49
query42	114	99	98	98
query43	543	508	503	503
query44	1216	836	821	821
query45	191	180	174	174
query46	1180	720	725	720
query47	2022	1877	1890	1877
query48	458	400	387	387
query49	731	388	375	375
query50	842	433	423	423
query51	7395	7182	7102	7102
query52	105	89	85	85
query53	264	183	180	180
query54	551	448	446	446
query55	75	75	78	75
query56	251	245	242	242
query57	1240	1125	1100	1100
query58	213	207	202	202
query59	3265	3240	2941	2941
query60	268	258	255	255
query61	160	106	109	106
query62	782	647	657	647
query63	212	194	194	194
query64	1376	659	646	646
query65	3253	3190	3207	3190
query66	705	300	309	300
query67	15890	15789	15515	15515
query68	4256	573	595	573
query69	431	263	269	263
query70	1163	1130	1075	1075
query71	361	252	245	245
query72	6499	4139	4108	4108
query73	763	347	353	347
query74	10116	9015	9087	9015
query75	3369	2651	2656	2651
query76	1926	1080	1043	1043
query77	484	271	273	271
query78	10593	9905	9978	9905
query79	1592	604	601	601
query80	1077	446	415	415
query81	530	245	237	237
query82	209	114	122	114
query83	168	145	151	145
query84	283	82	75	75
query85	976	291	294	291
query86	416	296	299	296
query87	4538	4233	4348	4233
query88	3583	2401	2337	2337
query89	415	291	289	289
query90	1994	193	184	184
query91	202	153	151	151
query92	65	48	50	48
query93	1740	539	538	538
query94	893	301	294	294
query95	360	263	260	260
query96	624	289	283	283
query97	3355	3161	3227	3161
query98	214	213	199	199
query99	1610	1288	1280	1280
Total cold run time: 317214 ms
Total hot run time: 197712 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.24 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2a430dd91d3fea297d535a054a5320c1edd904c7, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.11	0.10
query5	0.51	0.53	0.54
query6	1.13	0.74	0.73
query7	0.03	0.02	0.02
query8	0.03	0.03	0.03
query9	0.56	0.51	0.50
query10	0.55	0.56	0.54
query11	0.15	0.10	0.11
query12	0.15	0.11	0.13
query13	0.61	0.60	0.60
query14	2.97	2.89	3.06
query15	0.90	0.84	0.84
query16	0.39	0.36	0.38
query17	1.06	1.06	1.02
query18	0.23	0.22	0.21
query19	1.91	1.89	1.99
query20	0.02	0.01	0.00
query21	15.35	0.58	0.58
query22	2.64	3.04	1.45
query23	16.96	0.90	0.69
query24	3.63	1.76	1.95
query25	0.34	0.08	0.08
query26	0.54	0.13	0.15
query27	0.04	0.05	0.04
query28	9.11	1.12	1.08
query29	12.61	3.26	3.24
query30	0.24	0.06	0.06
query31	2.87	0.40	0.39
query32	3.23	0.46	0.45
query33	2.97	2.97	2.96
query34	16.66	4.46	4.47
query35	4.57	4.48	4.49
query36	0.69	0.48	0.50
query37	0.10	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.1 s
Total hot run time: 33.24 s

@cambyzju
Copy link
Contributor Author

run p0

@cambyzju
Copy link
Contributor Author

run external

@cambyzju
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40961 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4eb6a952e00ac0beec7559673bfec4dec47d1083, data reload: false

------ Round 1 ----------------------------------
q1	17567	7346	7198	7198
q2	2059	174	191	174
q3	10565	1085	1185	1085
q4	10555	770	764	764
q5	7740	2816	2776	2776
q6	234	148	143	143
q7	994	615	609	609
q8	9368	1966	2015	1966
q9	6645	6428	6394	6394
q10	7060	2257	2295	2257
q11	468	269	269	269
q12	402	231	212	212
q13	17786	2975	2959	2959
q14	238	217	206	206
q15	564	526	519	519
q16	693	623	605	605
q17	977	580	540	540
q18	7242	6713	6702	6702
q19	1426	1061	1045	1045
q20	472	206	191	191
q21	3986	3369	3390	3369
q22	1109	1037	978	978
Total cold run time: 108150 ms
Total hot run time: 40961 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7287	7236	7164	7164
q2	325	224	230	224
q3	2901	2910	2939	2910
q4	2066	1861	1827	1827
q5	5706	5687	5722	5687
q6	228	143	141	141
q7	2284	1792	1798	1792
q8	3351	3536	3529	3529
q9	8745	8838	8770	8770
q10	3597	3539	3552	3539
q11	592	522	503	503
q12	780	594	600	594
q13	9248	3166	3180	3166
q14	301	290	268	268
q15	571	510	538	510
q16	719	667	643	643
q17	1849	1620	1600	1600
q18	8252	7835	7514	7514
q19	1660	1471	1626	1471
q20	2064	1879	1824	1824
q21	5442	5335	5364	5335
q22	1145	1050	1057	1050
Total cold run time: 69113 ms
Total hot run time: 60061 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197492 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4eb6a952e00ac0beec7559673bfec4dec47d1083, data reload: false

query1	1262	909	914	909
query2	6246	2033	2031	2031
query3	10938	4409	4334	4334
query4	66772	28643	23367	23367
query5	4933	459	446	446
query6	415	180	179	179
query7	5500	312	316	312
query8	313	227	215	215
query9	8574	2671	2650	2650
query10	440	282	254	254
query11	17076	15305	15794	15305
query12	155	103	100	100
query13	1432	461	438	438
query14	10934	7139	7447	7139
query15	207	188	188	188
query16	6778	518	493	493
query17	1145	601	606	601
query18	1763	334	325	325
query19	207	163	161	161
query20	122	115	121	115
query21	206	105	114	105
query22	4904	4656	4636	4636
query23	34636	34049	34156	34049
query24	6103	2863	2954	2863
query25	566	426	434	426
query26	665	178	171	171
query27	1730	361	350	350
query28	4086	2495	2494	2494
query29	668	442	430	430
query30	243	162	161	161
query31	1030	841	831	831
query32	66	58	58	58
query33	403	280	284	280
query34	905	519	526	519
query35	869	712	721	712
query36	1107	947	978	947
query37	123	77	72	72
query38	4128	3931	4032	3931
query39	1507	1499	1471	1471
query40	208	97	97	97
query41	48	47	47	47
query42	107	102	104	102
query43	529	503	501	501
query44	1182	817	808	808
query45	186	173	172	172
query46	1143	747	728	728
query47	2043	1933	1942	1933
query48	502	387	387	387
query49	716	413	396	396
query50	846	428	430	428
query51	7353	7399	7199	7199
query52	104	87	88	87
query53	250	181	189	181
query54	555	441	459	441
query55	74	73	74	73
query56	251	239	241	239
query57	1242	1127	1130	1127
query58	215	203	208	203
query59	3237	3009	3123	3009
query60	276	257	249	249
query61	107	109	110	109
query62	768	682	667	667
query63	215	198	187	187
query64	1371	673	627	627
query65	3264	3165	3160	3160
query66	704	297	300	297
query67	16042	15684	15664	15664
query68	4134	567	555	555
query69	427	265	266	265
query70	1198	1095	1067	1067
query71	354	254	258	254
query72	6320	4083	3994	3994
query73	741	338	342	338
query74	10301	8904	9032	8904
query75	3344	2619	2652	2619
query76	1827	989	1086	989
query77	533	270	269	269
query78	10526	9676	9637	9637
query79	1550	589	605	589
query80	882	425	419	419
query81	511	240	235	235
query82	1262	116	124	116
query83	240	150	146	146
query84	282	85	77	77
query85	892	295	291	291
query86	352	297	295	295
query87	4469	4286	4192	4192
query88	3871	2411	2367	2367
query89	415	291	290	290
query90	2026	186	183	183
query91	175	147	150	147
query92	69	49	51	49
query93	1837	541	551	541
query94	810	306	290	290
query95	350	255	258	255
query96	623	278	287	278
query97	3339	3164	3191	3164
query98	209	212	211	211
query99	1594	1294	1280	1280
Total cold run time: 318158 ms
Total hot run time: 197492 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4eb6a952e00ac0beec7559673bfec4dec47d1083, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.11
query5	0.52	0.51	0.50
query6	1.13	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.51	0.48
query10	0.56	0.55	0.55
query11	0.15	0.11	0.10
query12	0.14	0.11	0.12
query13	0.60	0.61	0.60
query14	3.09	2.91	2.93
query15	0.88	0.84	0.83
query16	0.39	0.37	0.38
query17	1.05	1.05	1.00
query18	0.24	0.22	0.21
query19	1.96	1.88	2.02
query20	0.01	0.00	0.01
query21	15.37	0.57	0.58
query22	2.55	2.70	2.03
query23	16.96	0.95	0.76
query24	3.43	1.27	1.48
query25	0.33	0.20	0.07
query26	0.43	0.13	0.14
query27	0.04	0.03	0.04
query28	9.85	1.09	1.08
query29	12.56	3.26	3.22
query30	0.24	0.06	0.06
query31	2.88	0.39	0.38
query32	3.26	0.46	0.46
query33	3.01	2.98	3.03
query34	17.16	4.49	4.60
query35	4.55	4.53	4.51
query36	0.66	0.50	0.49
query37	0.10	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.15	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.06 s
Total hot run time: 33.36 s

Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy720 xy720 merged commit 895ddb6 into apache:branch-3.0 Jan 16, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants