Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](auth)Remove SerializedName tag of lock object in PasswordPolicy #45996

Closed
wants to merge 1 commit into from

Conversation

Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Dec 26, 2024

What problem does this PR solve?

lock object in PasswordPolicy is written to disk, when user upgrade from older version, this lock will be null, and cause user couldn't connect to Doris.

Code cause this issue in PasswordPolicy:

@SerializedName(value = "lock")
private ReentrantReadWriteLock lock = new ReentrantReadWriteLock();

Issue Number: close #xxx

Related PR: #44905

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 26, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review December 26, 2024 04:06
@Jibing-Li
Copy link
Contributor Author

run buildall

@Jibing-Li Jibing-Li changed the title [fix](auth)Fix bug of pr 44905 [fix](auth)Remove SerializedName tag of lock object in PasswordPolicy Dec 26, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 26, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 34131 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit da3ed6e1745522087ee80c63db47e77e5a9314c2, data reload: false

------ Round 1 ----------------------------------
q1	17584	6243	6125	6125
q2	2101	1375	1148	1148
q3	9964	1279	704	704
q4	10203	883	447	447
q5	7535	2248	1997	1997
q6	211	178	148	148
q7	919	787	602	602
q8	9248	1399	1231	1231
q9	5342	4943	4972	4943
q10	6745	2337	1859	1859
q11	483	276	276	276
q12	341	370	218	218
q13	17794	3750	2964	2964
q14	247	242	224	224
q15	590	530	508	508
q16	642	631	618	618
q17	566	853	324	324
q18	7554	6753	6737	6737
q19	1247	953	541	541
q20	324	309	183	183
q21	2878	2134	2033	2033
q22	362	340	301	301
Total cold run time: 102880 ms
Total hot run time: 34131 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6224	6245	6276	6245
q2	244	335	232	232
q3	2296	2699	2363	2363
q4	1383	1856	1377	1377
q5	4420	4859	4903	4859
q6	188	177	141	141
q7	2130	2005	1848	1848
q8	2662	2857	2769	2769
q9	7158	7273	7235	7235
q10	3055	3352	2826	2826
q11	588	518	532	518
q12	700	783	632	632
q13	3461	3874	3171	3171
q14	302	303	287	287
q15	601	554	524	524
q16	651	693	655	655
q17	1272	1768	1268	1268
q18	8026	7631	7399	7399
q19	862	1111	1157	1111
q20	2071	2096	1900	1900
q21	5795	5329	5065	5065
q22	639	620	607	607
Total cold run time: 54728 ms
Total hot run time: 53032 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196746 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit da3ed6e1745522087ee80c63db47e77e5a9314c2, data reload: false

query1	1321	965	980	965
query2	5933	2383	2233	2233
query3	10984	5048	4852	4852
query4	33634	23859	23408	23408
query5	5084	640	475	475
query6	295	205	183	183
query7	3999	529	309	309
query8	312	261	232	232
query9	9545	2762	2728	2728
query10	488	295	248	248
query11	18260	15495	15312	15312
query12	161	113	105	105
query13	1599	557	406	406
query14	10612	7544	7411	7411
query15	249	210	189	189
query16	7578	614	430	430
query17	1574	767	565	565
query18	1418	407	348	348
query19	220	201	175	175
query20	133	120	122	120
query21	215	128	124	124
query22	4821	4571	4531	4531
query23	34528	33650	33518	33518
query24	6489	2273	2313	2273
query25	477	498	399	399
query26	1162	270	155	155
query27	2185	484	344	344
query28	5469	2511	2481	2481
query29	635	576	423	423
query30	216	186	148	148
query31	1040	913	847	847
query32	73	64	57	57
query33	504	330	291	291
query34	809	863	524	524
query35	838	864	756	756
query36	1044	1041	951	951
query37	120	104	73	73
query38	4315	4469	4095	4095
query39	1539	1504	1457	1457
query40	215	113	101	101
query41	46	45	45	45
query42	125	110	101	101
query43	500	539	494	494
query44	1396	820	824	820
query45	184	174	164	164
query46	896	1113	663	663
query47	2017	1978	1846	1846
query48	388	437	311	311
query49	772	478	387	387
query50	644	666	396	396
query51	7172	7153	7157	7153
query52	103	95	89	89
query53	227	260	183	183
query54	479	489	406	406
query55	83	80	77	77
query56	258	261	239	239
query57	1230	1201	1116	1116
query58	237	230	220	220
query59	3019	3041	3084	3041
query60	271	262	252	252
query61	109	109	112	109
query62	840	809	740	740
query63	222	188	186	186
query64	3868	1063	643	643
query65	3299	3206	3201	3201
query66	919	402	300	300
query67	16020	16126	15550	15550
query68	7780	792	538	538
query69	511	286	256	256
query70	1227	1036	1144	1036
query71	453	300	269	269
query72	6187	4148	3888	3888
query73	670	762	362	362
query74	10014	9067	9168	9067
query75	4058	3148	2659	2659
query76	3840	1208	776	776
query77	786	384	271	271
query78	10168	10192	9366	9366
query79	2777	905	597	597
query80	562	532	447	447
query81	483	265	230	230
query82	583	149	125	125
query83	167	164	146	146
query84	230	99	70	70
query85	794	363	369	363
query86	371	298	303	298
query87	4374	4435	4508	4435
query88	4866	2256	2188	2188
query89	430	335	294	294
query90	1931	193	190	190
query91	135	131	106	106
query92	67	57	55	55
query93	2003	924	552	552
query94	642	387	289	289
query95	338	259	256	256
query96	492	613	277	277
query97	2769	2823	2702	2702
query98	231	196	199	196
query99	1476	1528	1468	1468
Total cold run time: 296832 ms
Total hot run time: 196746 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.53 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit da3ed6e1745522087ee80c63db47e77e5a9314c2, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.11
query5	0.44	0.43	0.43
query6	1.14	0.68	0.66
query7	0.03	0.02	0.01
query8	0.04	0.03	0.04
query9	0.59	0.51	0.52
query10	0.56	0.56	0.56
query11	0.16	0.10	0.11
query12	0.15	0.10	0.12
query13	0.62	0.60	0.61
query14	2.69	2.76	2.88
query15	0.90	0.83	0.82
query16	0.38	0.40	0.39
query17	1.02	1.05	1.01
query18	0.22	0.22	0.21
query19	1.93	1.75	1.96
query20	0.01	0.02	0.01
query21	15.36	0.95	0.60
query22	0.77	0.77	0.63
query23	15.35	1.48	0.56
query24	2.93	1.18	1.33
query25	0.22	0.14	0.09
query26	0.24	0.16	0.14
query27	0.05	0.06	0.05
query28	14.44	1.59	1.05
query29	12.62	3.97	3.31
query30	0.24	0.09	0.06
query31	2.83	0.63	0.38
query32	3.22	0.56	0.47
query33	3.12	3.22	3.14
query34	16.72	5.23	4.43
query35	4.45	4.45	4.46
query36	0.64	0.52	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 106.53 s
Total hot run time: 31.53 s

@Jibing-Li Jibing-Li closed this Dec 26, 2024
@Jibing-Li Jibing-Li deleted the fix44905 branch December 26, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants