-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement faster join traversal #14539
Draft
Dandandan
wants to merge
7
commits into
apache:main
Choose a base branch
from
Dandandan:join_vectorization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
force-pushed
the
join_vectorization
branch
from
February 7, 2025 08:35
7d1caf4
to
a6c8ee5
Compare
Dandandan
changed the title
[WIP] Implement faster join algorithm
[WIP] Implement faster join traversal
Feb 7, 2025
Dandandan
changed the title
[WIP] Implement faster join traversal
Implement faster join traversal
Feb 9, 2025
Update after implementing emitting in batch size: in memory performs about the same as before, but tpch_10 regressed compared to earlier implementation (so the diff there seems more having to with output batch size in some way). |
This is ready for review |
seeing some regressions in imdb benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We can speed up finding matching indices by separating the lookups and chain traversal.
Todo
Rationale for this change
What changes are included in this PR?
This simplifies the algorithm for traversing the chain and makes it more vectorizable.
Are these changes tested?
Are there any user-facing changes?