Add tests for coercing sub fields of Lists / LargeLists of structs
#14381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
Lists / LargeLists of structs
alamb
commented
Jan 31, 2025
| case when not column1 then column2 else column3 end | ||
| from t; | ||
| ---- | ||
| [{c0: bar}] [{c0: bar}] |
There was a problem hiding this comment.
this is clearly wrong -- it should have 'foo' as the field name
|
real fix in #14385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
We don't have test coverage for having to coerce
List(Struct)-->LargeList(Struct)where some of the innerStructfields need to be coerced tooWhat changes are included in this PR?
to_large_listtesting function to coerceList-->LargeList(otherwise I can't createLargeListofStruct) 🤔Are these changes tested?
Yes, all tests
Are there any user-facing changes?