Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory pool error type #1346

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

kazuyukitanimura
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Datafusion memory pool throws insufficient_capacity_err https://github.com/apache/datafusion/blob/main/datafusion/execution/src/memory_pool/pool.rs#L91
and aggregation expects to see it https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/aggregates/row_hash.rs#L913

However comet memory pool was throwing an execution error that causes false OOM

How are these changes tested?

existing tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.09%. Comparing base (f09f8af) to head (9a62fe6).
Report is 9 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1346       +/-   ##
=============================================
- Coverage     56.12%   39.09%   -17.04%     
- Complexity      976     2065     +1089     
=============================================
  Files           119      260      +141     
  Lines         11743    60237    +48494     
  Branches       2251    12817    +10566     
=============================================
+ Hits           6591    23548    +16957     
- Misses         4012    32205    +28193     
- Partials       1140     4484     +3344     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks @kazuyukitanimura.

@andygrove andygrove merged commit c518b78 into apache:main Jan 28, 2025
75 checks passed
@kazuyukitanimura
Copy link
Contributor Author

Thanks @andygrove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants