Feat: support array_except function #1343
Open
+120
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
============================================
+ Coverage 56.12% 57.45% +1.32%
Complexity 976 976
============================================
Files 119 121 +2
Lines 11743 11931 +188
Branches 2251 2254 +3
============================================
+ Hits 6591 6855 +264
+ Misses 4012 3917 -95
- Partials 1140 1159 +19 ☔ View full report in Codecov by Sentry. |
andygrove
reviewed
Jan 27, 2025
added 3 commits
January 28, 2025 19:53
# Conflicts: # native/core/src/execution/planner.rs # native/proto/src/proto/expr.proto # spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala # spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
added 5 commits
January 30, 2025 19:23
# Conflicts: # spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala # spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
andygrove
approved these changes
Feb 3, 2025
| sql("SELECT array_except(array(_2, _3, _4), array(_3, _4)) from t1")) | ||
| checkSparkAnswerAndOperator(sql("SELECT array_except(array(_18), array(_19)) from t1")) | ||
| checkSparkAnswerAndOperator(spark.sql( | ||
| "SELECT array_except((CASE WHEN _2 = _3 THEN array(_2, _3, _4) END), array(_4)) FROM t1")) |
There was a problem hiding this comment.
_2 = _3 would be always true?
| @@ -126,6 +126,21 @@ object CometArraysOverlap extends CometExpressionSerde with IncompatExpr { | |||
| } | |||
| } | |||
|
|
|||
| object CometArrayExcept extends CometExpressionSerde with CometExprShim { | |||
There was a problem hiding this comment.
Any reason for using CometExprShim?
Also not sure how ready this is regarding Spark compatibility although it seems the test coverage is good. Adding IncompatExpr might be an option.
| @@ -2387,6 +2387,8 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim | |||
| case _: ArrayIntersect => convert(CometArrayIntersect) | |||
| case _: ArrayJoin => convert(CometArrayJoin) | |||
| case _: ArraysOverlap => convert(CometArraysOverlap) | |||
| case _ if expr.prettyName == "array_except" => | |||
There was a problem hiding this comment.
Is ArrayExcept available only for newer version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to Epic: #1042
array_except: SELECT array_except(array(1, 2, 3), array(1, 3, 5)) => array(2)
DataFusion' s array_except has same behavior with Spark 's array_except function
Spark: https://docs.databricks.com/en/sql/language-manual/functions/array_except.html
DataFusion: https://datafusion.apache.org/user-guide/sql/scalar_functions.html#array-except
Rationale for this change
Defined under Epic: #1042
What changes are included in this PR?
planner.rs: Maps Spark 's array_except function to DataFusion array_except_udf physical expression from Spark physical expression
expr.proto: array_except array_except has been added,
QueryPlanSerde.scala: arrays_except pattern matching case has been added,
CometExpressionSuite.scala: A new UT has been added for array_except function.
How are these changes tested?
A new UT has been added.