-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Hyper is powering our `_approx_count_distinct` reducer. The dependency isn't updated much and there is an under-counting bug discussed in issue #5084. There is a more active fork [1], but moving to it is not practical as the context records are changed. Unfortunately for us, those are part of the on-disk indexing data structures. If we change them we risk breaking users' views. Additionally, we're not using most of the hyper library functionality: we only use one backend, one precision value (11), and only a few API functions. In light of that it makes sense to simplify the library and remove all the un-used stuff. Also, add 100% test coverage, and fix the bug found by the LivewareProblems/hyper fork. In order to ensure we don't inadvertently modify the on-disk records those are marked with a comment, and there is unit test that would break if we change them. The existing record structure is kept as-is for that exact reason including the silly mention of the `{hyper_binary, ...}` atom in the registers field, just to ensure there are no compatibility issues for our users' views. Fix #5084 [1] LivewareProblems/hyper
- Loading branch information
Showing
10 changed files
with
975 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,7 +58,6 @@ src/fauxton/ | |
src/folsom/ | ||
src/hackney/ | ||
src/hqueue/ | ||
src/hyper/ | ||
src/ibrowse/ | ||
src/idna/ | ||
src/jiffy/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -153,7 +153,6 @@ defmodule CouchDBTest.Mixfile do | |
"proper", | ||
"mochiweb", | ||
"meck", | ||
"hyper", | ||
"fauxton" | ||
] | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,7 +48,6 @@ | |
couch_event, | ||
ioq, | ||
couch_stats, | ||
hyper, | ||
couch_dist, | ||
couch_quickjs | ||
]}, | ||
|
Oops, something went wrong.