fix(android): remove WRITE_EXTERNAL_PERMISSION #915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
This was intended to be part of #909
But I forgot to sync the change to
plugin.xml
Description
Removes the automatic declaration for
WRITE_EXTERNAL_STORAGE
, letting end users add it to their config.xml if they need it depending on their use cases.Testing
YOLO paramedic (j.k. I've done lots of testing with and without the declaration)
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)