Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Description as optional in network acl list #10343

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

sudo87
Copy link
Contributor

@sudo87 sudo87 commented Feb 7, 2025

Description

This PR makes Description as optional field in ACL list additional screen, which is optional in API.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2025-02-07 17-54-31

How Has This Been Tested?

Tested on QA server.

How did you try to break this feature and the system with this change?

@sudo87 sudo87 force-pushed the optional-desc-acl-list branch from 8e0acb5 to 6a6f9b5 Compare February 7, 2025 12:35
@sudo87
Copy link
Contributor Author

sudo87 commented Feb 7, 2025

@blueorangutan ui

@blueorangutan
Copy link

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.00%. Comparing base (c5afee2) to head (6a6f9b5).
Report is 1 commits behind head on 4.20.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #10343   +/-   ##
=========================================
  Coverage     16.00%   16.00%           
  Complexity    13062    13062           
=========================================
  Files          5644     5644           
  Lines        494915   494915           
  Branches      59960    59960           
=========================================
  Hits          79187    79187           
- Misses       406891   406892    +1     
+ Partials       8837     8836    -1     
Flag Coverage Δ
uitests 4.01% <ø> (ø)
unittests 16.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10343 (QA-JID-545)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in qa

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

@DaanHoogland DaanHoogland merged commit 50a54dd into apache:4.20 Feb 7, 2025
26 checks passed
@DaanHoogland DaanHoogland deleted the optional-desc-acl-list branch February 7, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants