-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Description as optional in network acl list #10343
Conversation
8e0acb5
to
6a6f9b5
Compare
@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10343 +/- ##
=========================================
Coverage 16.00% 16.00%
Complexity 13062 13062
=========================================
Files 5644 5644
Lines 494915 494915
Branches 59960 59960
=========================================
Hits 79187 79187
- Misses 406891 406892 +1
+ Partials 8837 8836 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in qa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm
Description
This PR makes Description as optional field in ACL list additional screen, which is optional in API.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested on QA server.
How did you try to break this feature and the system with this change?