Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce the minimum cgroup cpu shares value to 2 #10221

Open
wants to merge 2 commits into
base: 4.20
Choose a base branch
from
Open

fix: enforce the minimum cgroup cpu shares value to 2 #10221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f51aec9
fix: enforce the minimum cgroupv2 cpu shares to 2
phsm Jan 20, 2025
691a0ff
Update plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm…
phsm Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...rvisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2796,8 +2796,16 @@ public int calculateCpuShares(VirtualMachineTO vmTO) {

if (hostCpuMaxCapacity > 0) {
int updatedCpuShares = (int) Math.ceil((requestedCpuShares * CGROUP_V2_UPPER_LIMIT) / (double) hostCpuMaxCapacity);
LOGGER.debug(String.format("This host utilizes cgroupv2 (as the max shares value is [%s]), thus, the VM requested shares of [%s] will be converted to " +
"consider the host limits; the new CPU shares value is [%s].", hostCpuMaxCapacity, requestedCpuShares, updatedCpuShares));

/**
* Libvirt < 9.1.0 enforces the range [2, 262144] to both cgroupv1 and cgroupv2.
* Therefore, if the shares value is determined to be < 2, then raise it to 2 to fit into the constraint.
* See: https://github.com/libvirt/libvirt/commit/38af6497610075e5fe386734b87186731d4c17ac
*/
if (updatedCpuShares < 2) updatedCpuShares = 2;

LOGGER.debug("This host utilizes cgroupv2 (as the max shares value is [{}]), thus, the VM requested shares of [{}] will be converted to " +
"consider the host limits; the new CPU shares value is [{}].", hostCpuMaxCapacity, requestedCpuShares, updatedCpuShares);
return updatedCpuShares;
}
LOGGER.debug(String.format("This host does not have a maximum CPU shares set; therefore, this host utilizes cgroupv1 and the VM requested CPU shares [%s] will not be " +
Expand Down
Loading