linstor: Fix ZFS snapshot backup

[rp-]

Description

Linstor plugin used the wrong zfs dataset path to hide/unhide the snapshot device.
Also don't use the full path to the zfs binary.

Fixes: #9360

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Linstor cluster with zfs storage backend.

How did you try to break this feature and the system with this change?

[DaanHoogland]

clgtm

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 15.13%. Comparing base (00c659b) to head (0c6b3fc).
Report is 3 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...e/wrapper/LinstorBackupSnapshotCommandWrapper.java	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10219   +/-   ##
=========================================
  Coverage     15.13%   15.13%           
- Complexity    11275    11279    +4     
=========================================
  Files          5408     5408           
  Lines        474003   474006    +3     
  Branches      57821    57822    +1     
=========================================
+ Hits          71729    71743   +14     
+ Misses       394256   394242   -14     
- Partials       8018     8021    +3     

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.85% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rp-]

noticed on some zfs distribution, the direct /dev/zpool/volume path is not always created, the safer variant is to use /dev/zvol/zpool/...

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12142

[harikrishna-patnala]

code LGTM