-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: list backup offerings by zoneid when assign vm to backup offering #10217
base: 4.19
Are you sure you want to change the base?
UI: list backup offerings by zoneid when assign vm to backup offering #10217
Conversation
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10217 +/- ##
============================================
+ Coverage 15.13% 15.85% +0.72%
- Complexity 11274 11278 +4
============================================
Files 5408 5042 -366
Lines 474003 444433 -29570
Branches 57821 52641 -5180
============================================
- Hits 71729 70473 -1256
+ Misses 394256 366083 -28173
+ Partials 8018 7877 -141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
@rajujith can you test this? |
Description
This PR fixes #9895
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?