Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: list backup offerings by zoneid when assign vm to backup offering #10217

Open
wants to merge 1 commit into
base: 4.19
Choose a base branch
from

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes #9895

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10217 (QA-JID-514)

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.85%. Comparing base (c5e8f63) to head (8ae6ee1).
Report is 1 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10217      +/-   ##
============================================
+ Coverage     15.13%   15.85%   +0.72%     
- Complexity    11274    11278       +4     
============================================
  Files          5408     5042     -366     
  Lines        474003   444433   -29570     
  Branches      57821    52641    -5180     
============================================
- Hits          71729    70473    -1256     
+ Misses       394256   366083   -28173     
+ Partials       8018     7877     -141     
Flag Coverage Δ
uitests ?
unittests 15.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache weizhouapache marked this pull request as ready for review January 22, 2025 13:23
@weizhouapache weizhouapache added this to the 4.19.2 milestone Jan 28, 2025
@DaanHoogland
Copy link
Contributor

@rajujith can you test this?

@rajujith rajujith self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Backup offerings of all zones are listed for any instance
5 participants