Enforce distinct hostnames network

[vishesh92]

Description

Fixes #9775

This PR adds check to ensure we check for unique hostname for other networks in the VPC as well.

This PR also adds another global setting vm.distinct.hostname.scope which sets the scope of resources for which the VMs should have a unique hostname. Default value is network.

Details

This pull request includes several changes to enhance the network domain search functionality and improve the configuration management for VM hostname uniqueness. The most important changes include adding new methods for network domain searches, updating the search builder initialization, and modifying the hostname uniqueness check logic.

Enhancements to network domain search functionality:

• engine/schema/src/main/java/com/cloud/network/dao/NetworkDao.java: Added new methods listByNetworkDomains, listByNetworkDomainsAndAccountIds, and listByNetworkDomainsAndDomainIds to the NetworkDao interface.
• engine/schema/src/main/java/com/cloud/network/dao/NetworkDaoImpl.java: Added NetworkDomainSearch to the NetworkDaoImpl class and initialized it in the init method. Implemented the new methods for network domain searches. [1] [2] [3]

Improvements to VM hostname uniqueness check:

• server/src/main/java/com/cloud/vm/UserVmManager.java: Introduced a new configuration key VmDistinctHostNameScope to manage the scope of hostname uniqueness checks.
• server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: Updated the logic for checking hostname uniqueness to use the new network domain search methods and the VmDistinctHostNameScope configuration. [1] [2]

Mock implementation updates:

• server/src/test/java/com/cloud/vpc/dao/MockNetworkDaoImpl.java: Added mock implementations for the new network domain search methods.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 1.25000% with 79 lines in your changes missing coverage. Please review.

Project coverage is 15.85%. Comparing base (9967bb3) to head (91344bf).
Report is 5 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	57 Missing ⚠️
...ain/java/com/cloud/network/dao/NetworkDaoImpl.java	0.00%	22 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10212      +/-   ##
============================================
+ Coverage     15.13%   15.85%   +0.72%     
- Complexity    11274    11279       +5     
============================================
  Files          5408     5042     -366     
  Lines        473974   444507   -29467     
  Branches      57813    52651    -5162     
============================================
- Hits          71730    70474    -1256     
+ Misses       394227   366156   -28071     
+ Partials       8017     7877     -140     

Flag	Coverage Δ
uitests	?
unittests	15.85% <1.25%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12125

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12130

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12144

[vishesh92]

@blueorangutan test

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests