ui: fix empty source cidr value for firewall rule

[shwstppr]

Description

Fixes #10002

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build failed: ✖️
(SL-JID-509)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.13%. Comparing base (9967bb3) to head (5cdbc39).

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10208      +/-   ##
============================================
- Coverage     15.13%   15.13%   -0.01%     
+ Complexity    11274    11270       -4     
============================================
  Files          5408     5408              
  Lines        473974   473976       +2     
  Branches      57813    57814       +1     
============================================
- Hits          71730    71713      -17     
- Misses       394227   394249      +22     
+ Partials       8017     8014       -3     

Flag	Coverage Δ
uitests	4.30% <ø> (-0.01%)	⬇️
unittests	15.85% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10208 (QA-JID-510)

[abh1sar]

LGTM.

p.s. what would be the behaviour if the same was done using api (Passing empty string cidr)? If it is the same, can we sanitise the input or throw some error from the api?