Skip to content
This repository has been archived by the owner on Jan 20, 2021. It is now read-only.

Show display text instead of name #844

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ravening
Copy link
Member

@ravening ravening commented Nov 4, 2020

While creating networks, for network offerings, show meaningful display text
instead of short names which is not much descriptive

Screenshot 2020-11-04 at 17 07 36

For network offerings, show meaningful display text
instead of short names which is not much descriptive
@rohityadavcloud rohityadavcloud added this to the 1.0-GA milestone Nov 4, 2020
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to check how legacy UI shows the name (name vs displayname vs description)

@ravening
Copy link
Member Author

ravening commented Nov 4, 2020

LGTM, but we need to check how legacy UI shows the name (name vs displayname vs description)

@rhtyd legacy ui displays name but it wont make sense just by looking at the name. displaytext gives more info about the offering

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

+1 on using display name as a user-friendly identification.

To be honest, sometimes I don't see much value in the displayname field; I think that this is indeed how it should be used.

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Nov 5, 2020

@ravening we may need to build consensus then, we largely want Primate 1.0/GA to be backwards compatible wrt UX, so changing how a field is displayed may break several people's env who were used to seeing the name. (To satisfy everyone - one solution could be showing the name and in parenthesis the displayname).

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@rohityadavcloud rohityadavcloud modified the milestones: 1.0-GA, 1.1 Nov 5, 2020
@rohityadavcloud
Copy link
Member

For now, moved to 1.1 as this is not a blocker or critical issue.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/844 (JID-3644)

@@ -125,7 +125,7 @@
:placeholder="this.$t('label.networkofferingid')"
@change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }">
<a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex">
{{ opt.name || opt.description }}
{{ opt.displaytext || opt.description }}
</a-select-option>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravening can this be: opt.displaytext | opt.name | ... to cover for the case if/when displaytext is empty?

@@ -125,7 +125,7 @@
:placeholder="this.$t('label.networkofferingid')"
@change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }">
<a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex">
{{ opt.name || opt.description }}
{{ opt.displaytext || opt.description }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravening can this be: opt.displaytext | opt.name | ... to cover for the case if/when displaytext is empty?

@@ -284,7 +284,7 @@
:placeholder="this.$t('label.networkofferingid')"
@change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }">
<a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex">
{{ opt.name || opt.description }}
{{ opt.displaytext || opt.description }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravening can this be: opt.displaytext | opt.name | ... to cover for the case if/when displaytext is empty?

@rohityadavcloud
Copy link
Member

cc @davidjumani

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants