-
Notifications
You must be signed in to change notification settings - Fork 38
Show display text instead of name #844
base: master
Are you sure you want to change the base?
Conversation
For network offerings, show meaningful display text instead of short names which is not much descriptive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we need to check how legacy UI shows the name (name vs displayname vs description)
@rhtyd legacy ui displays name but it wont make sense just by looking at the name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1 on using display name as a user-friendly identification.
To be honest, sometimes I don't see much value in the displayname field; I think that this is indeed how it should be used.
@ravening we may need to build consensus then, we largely want Primate 1.0/GA to be backwards compatible wrt UX, so changing how a field is displayed may break several people's env who were used to seeing the name. (To satisfy everyone - one solution could be showing the name and in parenthesis the displayname). @blueorangutan package |
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
For now, moved to 1.1 as this is not a blocker or critical issue. |
Packaging result: ✔️centos ✔️debian ✔️archive. |
@@ -125,7 +125,7 @@ | |||
:placeholder="this.$t('label.networkofferingid')" | |||
@change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }"> | |||
<a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex"> | |||
{{ opt.name || opt.description }} | |||
{{ opt.displaytext || opt.description }} | |||
</a-select-option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravening can this be: opt.displaytext | opt.name | ...
to cover for the case if/when displaytext is empty?
@@ -125,7 +125,7 @@ | |||
:placeholder="this.$t('label.networkofferingid')" | |||
@change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }"> | |||
<a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex"> | |||
{{ opt.name || opt.description }} | |||
{{ opt.displaytext || opt.description }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravening can this be: opt.displaytext | opt.name | ...
to cover for the case if/when displaytext is empty?
@@ -284,7 +284,7 @@ | |||
:placeholder="this.$t('label.networkofferingid')" | |||
@change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }"> | |||
<a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex"> | |||
{{ opt.name || opt.description }} | |||
{{ opt.displaytext || opt.description }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravening can this be: opt.displaytext | opt.name | ...
to cover for the case if/when displaytext is empty?
cc @davidjumani |
While creating networks, for network offerings, show meaningful display text
instead of short names which is not much descriptive