[CELEBORN-1820] Failing to write and flush StreamChunk data should be counted as FETCH_CHUNK_FAIL #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s FETCH_CHUNK_FAIL.
mridulm
reviewed
Jan 5, 2025
| @@ -511,7 +511,8 @@ class FetchHandler( | |||
| client: TransportClient, | |||
| streamChunkSlice: StreamChunkSlice, | |||
| req: RequestMessage): Unit = { | |||
| logDebug(s"Received req from ${NettyUtils.getRemoteAddress(client.getChannel)}" + | |||
| val remoteAddr = NettyUtils.getRemoteAddress(client.getChannel) | |||
There was a problem hiding this comment.
Nice catch, this object is only used in some scenarios.
RexXiong
approved these changes
Jan 6, 2025
|
Merged into main(v0.6.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
writeAndFlushto send chunk data to client asynchronously. Failing to write and flush StreamChunk data to remote should be counted as FETCH_CHUNK_FAIL.Why are the changes needed?
It it important to monitor FETCH_CHUNK_FAIL count correctly.
Does this PR introduce any user-facing change?
How was this patch tested?