[CELEBORN-1818] Fix incorrect timeout exception when waiting on no pending writes #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfmcgrady
changed the title
RexXiong
reviewed
Jan 3, 2025
| @@ -507,7 +507,7 @@ protected synchronized long close( | |||
| } | |||
|
|
|||
| try { | |||
| waitOnNoPending(numPendingWrites); | |||
| waitOnNoPending(numPendingWrites, false); | |||
There was a problem hiding this comment.
Seems we no longer need to waitOnNoPending writes, only need waitOnNoPending flushes.
There was a problem hiding this comment.
Seems we no longer need to waitOnNoPending writes, only need waitOnNoPending flushes.
If waitOnNoPending writes is removed, I'm afraid there will be more unnecessary "file already closed" exception and revive operation.
There was a problem hiding this comment.
Sounds reasonable, but maybe someone else need to take a look as well.
FMX
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Do not throw "Wait pending actions timeout" exception when waiting pending writes times out.
Why are the changes needed?
When pendingWrites is reduced to zero, the method waitOnNoPending will jump out of the while loop. Meanwhile, if new PushData/PushMergedData request comes, pendingWrites will increment and be larger then zero. As a result, "wait pending actions timeout" exception will be thrown in waitOnNoPending.
Does this PR introduce any user-facing change?
No
How was this patch tested?
manual test