HostFilter Not Used for Control Connection #1724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `HostFilter` is not being used for the Control Connection (aka the `controlConn`). This can be problematic, especially if the host is being filtered due to it being in a bad state, as it can hold up the creation of the Control Connection (and therefore the Session itself) for quite some time.
| // filter hosts at the onset to avoid using using filtered hosts in the control connection while | ||
| // discovering the protocol and/or connecting. | ||
| if s.cfg.HostFilter != nil { | ||
| newHosts := make([]*HostInfo, 0, len(hosts)) |
There was a problem hiding this comment.
We can refactor to something like:
newHosts := hosts[:0]
to avoid allocating a new slice, but in general, it is a good suggestion to fix an issue.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HostFilteris not being used for the Control Connection (aka thecontrolConn). This can be problematic, especially if the host is being filtered due to it being in a bad state, as it can hold up the creation of the Control Connection (and therefore the Session itself) for quite some time.This also fixes an issue if
disableControlConn=trueand/orDisableInitialHostLookup=true, where the Ring is updated with the host, prior to filtering:https://github.com/gocql/gocql/blob/db6d5564dd6843cc08cc1d6c3642612adf94c618/session.go#L265-L268
Closes: #1723