-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CALCITE-6763] Optimize logic to select the tiles with the fewest rows #4125
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no tests - is there any code calling this function?
If yes, then it's perhaps fine - the behavior is not supposed to change.
core/src/main/java/org/apache/calcite/materialize/MaterializationService.java
Show resolved
Hide resolved
|
you can probably squash the commits |
…s Optim define tile
354f72a
to
9e1a346
Compare
Done. |
Quality Gate passedIssues Measures |
There are some comments in Jira from @julianhyde, so I will wait to merge this. |
OK. |
Our current logic using a PriorityQueue to select the tile with the fewest rows when multiple tiles are available. However, there are several potential issues:
We can optimize the code by keeping only a single bestCandidate tile to improve performance.