[CALCITE-6754] Remove deprecated method calling in Driver #4112
Conversation
|
Now calcite does not support the MINOR keyword. You can try to modify the commit message |
ILuffZhe
force-pushed
the
remove-usage
branch
from
37b62b4 to
038f919
Compare
ILuffZhe
changed the title
Thanks for your reminder. |
|
Just a comment, I think this PR is worth creating a jira |
Sure, I'll do it later this day. |
ILuffZhe
changed the title
ILuffZhe
force-pushed
the
remove-usage
branch
from
038f919 to
2aedece
Compare
|
@caicancai Hi, I've changed the commit info and filed a JIRA ticket, please take a look when you have time. |
|
| } | ||
|
|
||
| /** Returns a factory with which to create a {@link CalcitePrepare}. | ||
| * | ||
| * <p>Now deprecated; if you wish to use a custom prepare, overrides of this | ||
| * method will still work, but we prefer that you call | ||
| * <p>Now deprecated; if you wish to use a custom prepare, please call |
There was a problem hiding this comment.
Can't we override this method now?
There was a problem hiding this comment.
Yes, we can override createPrepare() to achieve the same goal.
Since createPrepareFactory() is deprecated, maybe we shouldn't call or override it any more.
No description provided.