Support sharding in WriteToFiles (tested for to_csv) #33612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @liferoad @ahmedabu98 |
ahmedabu98
reviewed
Jan 23, 2025
| @@ -522,7 +522,7 @@ class WriteToFiles(beam.PTransform): | |||
| # Too many files will add memory pressure to the worker, so we let it be 20. | |||
| MAX_NUM_WRITERS_PER_BUNDLE = 20 | |||
|
|
|||
| DEFAULT_SHARDING = 5 | |||
| DEFAULT_SHARDING = 1 | |||
There was a problem hiding this comment.
Is this change necessary? I think line 570 can just check if the input shards is None instead of referring to self.shards > 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #22923 by adding a special case for sharding with no destination, since I wasn't sure if sharding is applicable if there is a destination. Happy to rework this as needed.