AVRO-3088: [C++] Export CMake package config file #3299
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
| # This config sets the following variables in your project:: | ||
| # | ||
| # Avro_FOUND - true if Avro found on the system | ||
| # Avro_VERSION - version of the found Avro | ||
| # | ||
| # This config sets the following targets in your project:: | ||
| # | ||
| # Avro::avrocpp_shared | ||
| # Avro::avrocpp_static | ||
|
|
||
| @PACKAGE_INIT@ | ||
|
|
||
| include(CMakeFindDependencyMacro) | ||
|
|
||
| if(DEFINED CMAKE_MODULE_PATH) | ||
| set(AVRO_CMAKE_MODULE_PATH_OLD ${CMAKE_MODULE_PATH}) | ||
| else() | ||
| unset(AVRO_CMAKE_MODULE_PATH_OLD) | ||
| endif() | ||
| set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}") | ||
|
|
||
| find_dependency(ZLIB REQUIRED) | ||
| find_dependency(fmt REQUIRED) | ||
| if(@Snappy_FOUND@) | ||
| find_dependency(Snappy REQUIRED) | ||
| endif() | ||
| if(@Boost_FOUND@) | ||
| find_dependency(Boost 1.70 REQUIRED COMPONENTS system) | ||
| endif() | ||
|
|
||
| if(DEFINED AVRO_CMAKE_MODULE_PATH_OLD) | ||
| set(CMAKE_MODULE_PATH ${AVRO_CMAKE_MODULE_PATH_OLD}) | ||
| unset(AVRO_CMAKE_MODULE_PATH_OLD) | ||
| else() | ||
| unset(CMAKE_MODULE_PATH) | ||
| endif() | ||
|
|
||
| include("${CMAKE_CURRENT_LIST_DIR}/AvroTargets.cmake") | ||
|
|
||
| add_library(Avro::avrocpp_static ALIAS Avro::avrocpp_s) | ||
| add_library(Avro::avrocpp_shared ALIAS Avro::avrocpp) | ||
|
|
||
| check_required_components(Avro) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mark this dependency as required. I think this check if target exists is not needed. CMake will fail if it does not find Boost and all requested components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to make sure that the target with
Boost::namespace exists. Same forSnappy::snappyandZLIB::ZLIBThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snappy and ZLIB are not marked as required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boost is not required. It is required only when
AVRO_BUILD_TESTSorAVRO_USE_BOOSTis enabled.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what @mitjap was trying to say is that this
ifstatement is superfluous asfind_packageis called with aREQUIREDkeyword. It will fail by itself whenBoost::systemis not found, no need for doing it explicitlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is slightly different. CMIW, sometimes
Boost::systemtarget is not available even ifBoost_FOUNDis true since older Boost distributions may not addBoost::namespace.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say in that case maybe reflect this in an error message? At this point
Boost::systemis definitely available. But it would not be available as a target.Not sure however what would be the best error message in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the message. Please check again.