-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-4104: [Python]: Drop support for Python 3.7 and 3.8 #3221
base: main
Are you sure you want to change the base?
Conversation
TODO: Create a JIRA ticket if this is approved! |
Both of them are EOLed and cause problems with the CI checks Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
acc8faf
to
6e4296d
Compare
@@ -71,10 +71,6 @@ RUN apt-get -qqy update \ | |||
python3.10 \ | |||
python3.11 \ | |||
python3.11-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it time to add 3.12 here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that version 3.13 has been released, I think it's about time.
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@@ -21,7 +21,7 @@ on: | |||
pull_request: | |||
branches: [ main ] | |||
paths: | |||
- .github/workflows/test-lang-py.yml | |||
- .github/workflows/test-lang-py-ARM.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ARM64 VMs are self-hosted by ASF Infra and they use Ubuntu 20.04 with an old Python version in the OS repos ...
This should be re-worked to use Conda or something similar to install a newer version of Python.
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
e0342de
to
5bb4de0
Compare
Semi-duplicate of #3276 |
sudo update-alternatives --set python /usr/bin/python3.12 | ||
sudo update-alternatives --set python3 /usr/bin/python3.12 | ||
python3 -m pip install --upgrade pip setuptools tox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wuff, I don't know what version of pip python3-pip
gets us, but the code that caused the failure was removed in pypa/pip@6739f56, which was released in v21.0 (the first release of 2021).
Anyway, I guess to work around it we need to update pip using a version of python that is before 3.12. IIUC, python3.8 is still here, so python3.8 -m pip install --upgrade pip setuptools tox
.
(For now, at least, the latest pip is still compatible with python 3.8, or we might need to get more boot-strappy.)
Both of them are EOLed and cause problems with the CI checks
What is the purpose of the change
(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)
Verifying this change
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation