Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C++] Drop aws-cpp-sdk-config #45191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lahwaacz
Copy link

@lahwaacz lahwaacz commented Jan 7, 2025

Rationale for this change

Arch Linux has started splitting the aws-sdk-cpp into several packages and leaving out unused components avoids unnecessary packaging work.

What changes are included in this PR?

The config component of the AWS SDK is not used when building arrow and thus can be dropped:

ARROW_STATIC_INSTALL_INTERFACE_LIBS
aws-cpp-sdk-identity-management
aws-cpp-sdk-sts
aws-cpp-sdk-cognito-identity
aws-cpp-sdk-s3
aws-cpp-sdk-core)

Are these changes tested?

Are there any user-facing changes?

No.

Copy link

github-actions bot commented Jan 7, 2025

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@lahwaacz lahwaacz changed the title Drop aws-cpp-sdk-config MINOR: [C++] Drop aws-cpp-sdk-config Jan 7, 2025
@lahwaacz lahwaacz force-pushed the drop-aws-cpp-sdk-config branch from e087c93 to a545df9 Compare January 7, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant