Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45185: [C++][Parquet] Raise an error for invalid repetition levels when delimiting records #45186

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamreeve
Copy link
Contributor

@adamreeve adamreeve commented Jan 7, 2025

Rationale for this change

See #45185. Invalid repetition levels would previously only cause a fatal error in debug builds.

What changes are included in this PR?

Converts an existing ARROW_DCHECK_EQ of the repetition level with a check that will raise an exception in release builds too.

Are these changes tested?

Yes, using a new example file (apache/parquet-testing#67)

Are there any user-facing changes?

Yes, reading columns with invalid repetition levels as Arrow arrays will now raise an exception.

@raulcd
Copy link
Member

raulcd commented Jan 7, 2025

Note for others taking a look, tests won't be successful until we merge the parquet-testing PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants