WIP: [R] Verify CRAN release 18.1.0.1 #45173
Conversation
…45097) ### Rationale for this change Apache Thrift misses `#include <cstdint>` for `int64_t`: apache/thrift#3078 GCC 15 requires it. ### What changes are included in this PR? Apply apache/thrift#3078 only with GCC 15. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #45096 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Jonathan Keane <[email protected]>
jonkeane
requested review from
assignUser,
kou,
raulcd,
thisisnic,
kevingurney,
sgilmore10,
domoritz,
trxcllnt,
lidavidm and
CurtHagenlocher
as code owners
github-actions
bot
added
Component: R
Component: Parquet
Component: C++
Component: Python
Component: JavaScript
Component: C#
Component: Ruby
Component: FlightRPC
Component: Gandiva
Component: GLib
Component: MATLAB
Component: Documentation
Component: Swift
awaiting committer review
|
@github-actions crossbow submit --group r |
|
Revision: cc4e0f3 Submitted crossbow builds: ursacomputing/crossbow @ actions-0533803ddb
|
### Rationale for this change GitHub phased out R from their Ubuntu images in their 24.04 image and this job started failing because of it. We now need to install R ourselves if a job needs it and uses ubuntu-latest (>=24.04). ### What changes are included in this PR? Change in GHA workflow config to always install R. ### Are these changes tested? They're testing here with crossbow. ### Are there any user-facing changes? No. * GitHub Issue: #45069 Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
|
@github-actions crossbow submit r-binary-packages |
|
Revision: 133303e Submitted crossbow builds: ursacomputing/crossbow @ actions-e6592b6365
|
|
@github-actions crossbow submit r-binary-packages |
|
Revision: 6255228 Submitted crossbow builds: ursacomputing/crossbow @ actions-5e529189a9
|
|
@github-actions crossbow submit r-binary-packages |
|
Revision: cdd0b79 Submitted crossbow builds: ursacomputing/crossbow @ actions-68bea26e94
|
jonkeane
changed the title
|
I'm trying to get a release ready to send to CRAN before our 14 January deadline. The only operative change that this branch has is cc4e0f3 (I also had to backport @amoeba 's CI fixes thanks for those!). The binary job runs, but I don't actually know the process to get the binaries that are created in the CI job to the jfrog repository. @amoeba @assignUser any thoughts about what to do here? Is this a manual step (with key signing and all of that)? I wanted to make the version 18.1.0.1 (that's why the branch is named such) since it's just this one patch to a dependency, but our version number + binary finder only looks at the first three version components Line 967 in 3752109 |
Yes this. As there is no actual change to the binaries (we don't build them with GCC 15) we can just update the source tarball used for cran so we pass on an unreleased compiler version (... 🤦). Thanks for getting this ready and a happy new year! |
|
Thanks for working on this @jonkeane. Shipping the patch in the source tarball seems like the best approach to me too. |
|
Agreed |
|
+1 to the simpler approach given the reason we're doing it. Thanks @jonkeane! |
jonkeane
changed the title
…hanges" This reverts commit cdd0b79.
|
Thanks, all! I've got everything prepared and will submit on the seventh when CRAN is back open. |
This is minor and a non-official release to get past a GCC 15 error.
Caution
Do not merge this PR.
This PR is being used to prepare for the CRAN submission for 18.1.0.1.
See packaging checklist: #45172.